Skip to content

/ jenkins

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on Windows #2763

Merged
merged 17 commits into from Feb 26, 2017
Merged

Fix tests on Windows #2763

merged 17 commits into from Feb 26, 2017

Conversation

@daniel-beck
Copy link
Member

daniel-beck commented Feb 26, 2017 •
edited

Re-run of #2745 from a committer in the hopes that this PR picks up the Windows test in the Jenkinsfile.
daniel-beck and others added 17 commits Feb 8, 2017
@daniel-beck
Add Windows build back
Loading status checks…
1047a2a 
This will allow PRs to resolve failing tests on Windows
@slide
Fix some tests on Windows.
Verified
This commit was signed with a verified signature.
slide Alex Earl
GPG key ID: 55FF3FA5B6A2D17F Learn about signing commits
Loading status checks…
d416d8a
@slide
More fixes for Windows
Verified
This commit was signed with a verified signature.
slide Alex Earl
GPG key ID: 55FF3FA5B6A2D17F Learn about signing commits
Loading status checks…
a5c6a5c
@slide
Fix more tests on Windows
Verified
This commit was signed with a verified signature.
slide Alex Earl
GPG key ID: 55FF3FA5B6A2D17F Learn about signing commits
Loading status checks…
d3f7550
@slide
More fixes
Verified
This commit was signed with a verified signature.
slide Alex Earl
GPG key ID: 55FF3FA5B6A2D17F Learn about signing commits
Loading status checks…
39a353d
@slide
More test fixes
Verified
This commit was signed with a verified signature.
slide Alex Earl
GPG key ID: 55FF3FA5B6A2D17F Learn about signing commits
Loading status checks…
757997f
@slide
Fingerprint tests passing
Verified
This commit was signed with a verified signature.
slide Alex Earl
GPG key ID: 55FF3FA5B6A2D17F Learn about signing commits
Loading status checks…
3d778c1
@slide
Fix some tests and skip some tests.
Verified
This commit was signed with a verified signature.
slide Alex Earl
GPG key ID: 55FF3FA5B6A2D17F Learn about signing commits
Loading status checks…
7143554
@slide
More ignores
Verified
This commit was signed with a verified signature.
slide Alex Earl
GPG key ID: 55FF3FA5B6A2D17F Learn about signing commits
Loading status checks…
3c4186f
@slide
Fix missing "j." before jenkins
Verified
This commit was signed with a verified signature.
slide Alex Earl
GPG key ID: 55FF3FA5B6A2D17F Learn about signing commits
Loading status checks…
251a2ea
@slide
Try /nobreak for timeout command.
Verified
This commit was signed with a verified signature.
slide Alex Earl
GPG key ID: 55FF3FA5B6A2D17F Learn about signing commits
Loading status checks…
23d3746
@slide
Replace timeout with ping solution (Thanks Windows)
Verified
This commit was signed with a verified signature.
slide Alex Earl
GPG key ID: 55FF3FA5B6A2D17F Learn about signing commits
Loading status checks…
9491f77
@slide
Remove commented code
Verified
This commit was signed with a verified signature.
slide Alex Earl
GPG key ID: 55FF3FA5B6A2D17F Learn about signing commits
Loading status checks…
3d38ec9
@slide
Update to use EchoCommand from test harness and some formatting.
Verified
This commit was signed with a verified signature.
slide Alex Earl
GPG key ID: 55FF3FA5B6A2D17F Learn about signing commits
Loading status checks…
f604102
@slide
Fix parsing so that the test can complete.
Verified
This commit was signed with a verified signature.
slide Alex Earl
GPG key ID: 55FF3FA5B6A2D17F Learn about signing commits
Loading status checks…
223151e
@slide
This is really just to get another build.
Verified
This commit was signed with a verified signature.
slide Alex Earl
GPG key ID: 55FF3FA5B6A2D17F Learn about signing commits
Loading status checks…
30bac62
@slide
Fix ip address
Verified
This commit was signed with a verified signature.
slide Alex Earl
GPG key ID: 55FF3FA5B6A2D17F Learn about signing commits
Loading status checks…
513d7e0
@daniel-beck
Copy link
Member Author

daniel-beck commented Feb 26, 2017

Looks like I'm trusted, so this can be merged. Notably, should not be squashed despite the bloated history, otherwise I think @slide is no longer attributed.
@oleg-nenashev
oleg-nenashev approved these changes Feb 26, 2017
View changes
Copy link
Member

oleg-nenashev left a comment

:shipit:
@slide
Copy link
Member

slide commented Feb 26, 2017

I'm not worried about being attributed. Feel free to squash.
@daniel-beck daniel-beck merged commit 335fb4b into jenkinsci:master Feb 26, 2017
2 checks passed
2 checks passed
Jenkins This pull request looks good
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@jglick
Copy link
Member

jglick commented Mar 3, 2017

@slide seems like this caused a test regression in master

java.io.IOException: Unable to delete file: C:\Packages\Plugins\Microsoft.Compute.CustomScriptExtension\1.8\Downloads\0\workspace\Core_jenkins_master-CZB5BLBJFXZE2BKR63DSXQKXRZJAOWBX73QP55GU5KMX7AHAF6CQ\core\target\junit5522992408021127005\dir\x.log
	at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2279)
	at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653)
	at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1535)
	at hudson.util.io.RewindableRotatingFileOutputStreamTest.deletedFolder(RewindableRotatingFileOutputStreamTest.java:52)
@slide slide deleted the slide:windows-ci branch Mar 3, 2017
@slide
Copy link
Member

slide commented Mar 3, 2017 •
edited

@jglick the test is invalid on windows, I created #2774 to ignore the test
@jglick jglick mentioned this pull request Mar 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@daniel-beck @slide @jglick @oleg-nenashev
You can’t perform that action at this time.