Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore deletedFolder test on Windows #2774

Merged
merged 2 commits into from Mar 4, 2017
Merged

Conversation

@slide
Copy link
Member

slide commented Mar 3, 2017

Windows doesn't allow deleting directories that have a file open inside of them, so this test is invalid on windows.

Windows doesn't allow deleting directories that have a file open inside of them, so this test is invalid on windows.
@slide slide mentioned this pull request Mar 3, 2017
Copy link
Member

oleg-nenashev left a comment

👍

@jglick
Copy link
Member

jglick commented Mar 3, 2017

Amends #2763 & #2738.

@@ -14,6 +15,8 @@
import org.junit.rules.TemporaryFolder;
import org.jvnet.hudson.test.Issue;

import static org.junit.Assume.assumeFalse

This comment has been minimized.

Copy link
@jglick

jglick Mar 3, 2017

Member

missing semicolon

@jglick
jglick approved these changes Mar 3, 2017
@daniel-beck daniel-beck merged commit 5d7e58c into jenkinsci:master Mar 4, 2017
1 of 2 checks passed
1 of 2 checks passed
Jenkins Looks like there's a problem with this pull request
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.