New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SSHD Core to 1.10. #2796

Merged
merged 1 commit into from Mar 17, 2017

Conversation

3 participants
@oleg-nenashev
Member

oleg-nenashev commented Mar 11, 2017

Picks jenkinsci/sshd-module#9 from @daniel-beck . The new release also contains the in-repo changelog for the module. Full Diff

Tested manually before the release. Trivial change, hence no tests.

Changelog entries

Proposed changelog entries:

  • SSHD 1.10: Move SSH server port configuration to security options page.
  • ...

Submitter checklist

  • JIRA issue is well described
  • Link to JIRA ticket in description, if appropriate
  • Appropriate autotests or explanation to why this change has no tests
  • For new API and extension points: Link to the reference implementation in open-source (or example in Javadoc)

Desired reviewers

@daniel-beck

Update SSHD Core to 1.10.
Changelog:

* [PR #9](jenkinsci/sshd-module#9) - Move SSH server port configuration to security options page.
@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Mar 11, 2017

Member

Desired reviewers @daniel-beck

Nothing like reviewing my own change 😆

So, yeah, obviously I think this is a good idea.

Member

daniel-beck commented Mar 11, 2017

Desired reviewers @daniel-beck

Nothing like reviewing my own change 😆

So, yeah, obviously I think this is a good idea.

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Mar 11, 2017

Member

Mysteriously, both CI checks have passed. Wiee

Member

oleg-nenashev commented Mar 11, 2017

Mysteriously, both CI checks have passed. Wiee

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Mar 11, 2017

Member

@daniel-beck The change itself has been already reviewed. So approval of this PR is rather about "Do I miss anything in the update process?"

Member

oleg-nenashev commented Mar 11, 2017

@daniel-beck The change itself has been already reviewed. So approval of this PR is rather about "Do I miss anything in the update process?"

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev
Member

oleg-nenashev commented Mar 15, 2017

@jglick

jglick approved these changes Mar 15, 2017

Note: will probably conflict with #2795, since I expect to need to update sshd anyway.

@oleg-nenashev oleg-nenashev merged commit 255acda into jenkinsci:master Mar 17, 2017

2 checks passed

Jenkins This pull request looks good
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment