Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up localizations #2812

Merged
merged 1 commit into from Mar 22, 2017
Merged

Conversation

@daniel-beck
Copy link
Member

daniel-beck commented Mar 19, 2017

Proposed changelog entries

  • Remove Korean entries from Ukrainian localization.

Could probably skip; most other interesting changes are (also, mostly) implemented in #2813. And the bulk of this is removing "English to English" localizations, which doesn't seem notable.


So 😡 right now that this obvious nonsense was even committed. Even a cursory review reveals major problems.

  • Remove "localized" strings that are just English
  • Remove obvious vandalism
  • Remove obviously wrong translations (Korean script in Ukrainian localization? wtf?)
  • Remove Punjabi (pa_IN), and Shqip (sq, Albanian) localizations entirely.
    • I can't get anything useful out of Google Translate for the former. Not a strong reason to delete, but it's only a handful of translations (23) anyway, and I doubt THEY WRITE EVERYTHING IN ALL CAPS.
    • The latter is just obvious vandalism.

I also fixed a few obvious typos.

@batmat
Copy link
Member

batmat commented Mar 19, 2017

heh, the first file I looked at was modified by me with daniel-beck@9ff7cfc#diff-1372ea548f450eecdfe94c4cae0f9c9a I hope it's not me :-), I guess not, and guess you refer to that email where every submitted translations since like 2 years was all committed in a batch :-/.

@batmat
batmat approved these changes Mar 19, 2017
Copy link
Member

batmat left a comment

👍 and congrats, having worked quite a bit on some translations, I know how cumbersome this kind of work can be.

@@ -1,3 +0,0 @@
# This file is under the MIT License by authors

login=jnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnbnbnbnbnbnbjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhjhyyyyyyyyyyyyyyyyyyyyyyyyyyyuuuuuuuuuuuuuuuuuuuuuuuuyuuuuuuuuuuuuuuuyuuuuuuuuuuuuuuuuuuuuuuuuuttttttttttttttttttttttttttcfdffffffffgggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggg

This comment has been minimized.

Copy link
@batmat

batmat Mar 19, 2017

Member

wow, I wonder if really we have NL users? :-/

This comment has been minimized.

Copy link
@daniel-beck

daniel-beck Mar 19, 2017

Author Member

This isn't Dutch, but West Frisian, with 400k speakers.

@daniel-beck
Copy link
Member Author

daniel-beck commented Mar 20, 2017

@batmat Well, the English "localizations" are mostly harmless. The rest is much worse.

@daniel-beck
Copy link
Member Author

daniel-beck commented Mar 20, 2017

Also removed Gujarati here, as it seems to be written in two different scripts. No idea what's going on, but it's either getting removed here or in #2813.

Copy link
Member

oleg-nenashev left a comment

👍 from what I see. I wish to say the day when @github starts rendering property files in the UI

@daniel-beck daniel-beck merged commit b5914bb into jenkinsci:master Mar 22, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head This commit cannot be built
Details
Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.