New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-16337] ssh-cli-auth 1.4 #2840

Merged
merged 1 commit into from Apr 12, 2017

Conversation

3 participants
@jglick
Member

jglick commented Apr 11, 2017

Description

See JENKINS-16337.

Upstream changes, mainly jenkinsci/ssh-cli-auth-module#4.

Changelog entries

Proposed changelog entries:

  • JENKINS-16337: added form validation for public key list in user configuration screen.

Desired reviewers

@reviewbybees

@reviewbybees

This comment has been minimized.

Show comment
Hide comment
@reviewbybees

reviewbybees Apr 11, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

reviewbybees commented Apr 11, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@oleg-nenashev

In the module's parent POM maybe it makes sense to explicitly set the latest Jenkins LTS version in properties in order to get fresh annotations from the core.

🐝 anyway

@jglick

This comment has been minimized.

Show comment
Hide comment
@jglick

jglick Apr 11, 2017

Member

Annotations? Like @CheckForNull? Yeah, would be possible, though unlikely to change anything.

Member

jglick commented Apr 11, 2017

Annotations? Like @CheckForNull? Yeah, would be possible, though unlikely to change anything.

@jglick jglick merged commit 24df43f into jenkinsci:master Apr 12, 2017

2 checks passed

Jenkins This pull request looks good
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@jglick jglick deleted the jglick:ssh-cli-auth-JENKINS-16337 branch Apr 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment