Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-43825] - Refactor ProcessTree.Windows logic to propagate errors #2859

Merged
merged 5 commits into from Apr 28, 2017

Conversation

@oleg-nenashev
Copy link
Member

commented Apr 25, 2017

Description

See JENKINS-43825. This is a prerequisite for JENKINS-30782.

Details:

  • Decouple anonymous OSProcess class to WindowsOSProcess
  • Refactor logging
  • Introduce new private methods for propagating exceptions to killAll()

The changes to don influence the public API, so they are technically backportable. I would prefer to keep it in such way till the JENKINS-30782 fix gets integrated. But I can refactor the existing APIs if code reviewers think that propagating errors from getEnvironment() is a generic use-case for all platforms.

No tests, since the behavior does not change. The coverage of the low-level logic is achieved at the WinP library level: https://github.com/kohsuke/winp

Changelog entries

Proposed changelog entries:

  • Not required (?) - The only "visible" change is PID mentions in stacktraces
  • ...

Submitter checklist

  • JIRA issue is well described
  • Link to JIRA ticket in description, if appropriate
  • Appropriate autotests or explanation to why this change has no tests
  • For new API and extension points: Link to the reference implementation in open-source (or example in Javadoc)

Desired reviewers

@reviewbybees

@reviewbybees

This comment has been minimized.

Copy link

commented Apr 25, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@recampbell recampbell requested a review from stephenc Apr 25, 2017

@oleg-nenashev

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2017

@oleg-nenashev oleg-nenashev merged commit 1899f36 into jenkinsci:master Apr 28, 2017

2 checks passed

Jenkins This pull request looks good
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@oleg-nenashev

This comment has been minimized.

Copy link
Member Author

commented Apr 28, 2017

@mc1arke @stephenc thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.