Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Deprecate TimeUnit2 #2892
Details: see title, very small change. And 0 risk from a runtime perspective.
Proposed changelog entries:
N/A I don't even think this should have an entry in the changelog, should it?
There are dozens of usages of
TimeUnit2 in this repository. You should clean them up. (I know they are harmless, but as a matter of policy we should not be deprecating things with a claim that a full replacement is available, without proof that this is actually so in some representative code base.)
Agreed @jglick I actually have that change locally, but it fails for now because accmod either is limited or, more probably IIUC, has a bug wrt to enums.
In the end, the goal of actually deprecating
Sorry for the long-lived PRs :-(
Sep 18, 2017
1 check was pending
Or longer version: