jenkins-core: Bump jnr-posix version #2904

Merged
merged 1 commit into from Jun 2, 2017

Conversation

5 participants
@bgamari
Contributor

bgamari commented May 29, 2017

Description

This allows Jenkins slaves to run on AArch64.

Details: The version of jnr-posix previously shipped an extremely dated version of libffi which had no support for AArch64.

Changelog entries

Proposed changelog entries:

  • Update jnr-posix from 3.0.1 to 3.0.41 to pick improvements and fixes in the POSIX platforms support

Desired reviewers

@reviewbybees

@reviewbybees

This comment has been minimized.

Show comment
Hide comment
@reviewbybees

reviewbybees May 29, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck May 29, 2017

Member

PR build fails due to this being an untrusted PR branch and it expects a file added in #2890. Could you rebase onto current master?

Member

daniel-beck commented May 29, 2017

PR build fails due to this being an untrusted PR branch and it expects a file added in #2890. Could you rebase onto current master?

jenkins-core: Bump jnr-posix version
This allows Jenkins slaves to run on AArch64.
@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev May 30, 2017

Member

So the last AARCH64 support fix has been made 19 days ago: jnr/jnr-posix#101 . I think it worth just updating the lib in the weekly baseline to see how it flies. If the tests pass, of course

Member

oleg-nenashev commented May 30, 2017

So the last AARCH64 support fix has been made 19 days ago: jnr/jnr-posix#101 . I think it worth just updating the lib in the weekly baseline to see how it flies. If the tests pass, of course

@bgamari

This comment has been minimized.

Show comment
Hide comment
@bgamari

bgamari May 30, 2017

Contributor

I agree that newer would be even better. I am currently building Jenkins with jnr-posix master due to jnr/jnr-posix#105 and it works well both on Windows and aarch64/Linux.

Contributor

bgamari commented May 30, 2017

I agree that newer would be even better. I am currently building Jenkins with jnr-posix master due to jnr/jnr-posix#105 and it works well both on Windows and aarch64/Linux.

@jglick

jglick approved these changes May 30, 2017

The changelog should mention this.

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev May 30, 2017

Member

Yes, it seems the bump is going to address at least of couple of issues. @bgamari it would be great if you could provide a list of issues which were impacting your setup PRs 101 and 105 seem to be notabl, but I'd guess there is a bunch of other important changes. Is there a JNR changelog somewhere btw?

Member

oleg-nenashev commented May 30, 2017

Yes, it seems the bump is going to address at least of couple of issues. @bgamari it would be great if you could provide a list of issues which were impacting your setup PRs 101 and 105 seem to be notabl, but I'd guess there is a bunch of other important changes. Is there a JNR changelog somewhere btw?

@bgamari

This comment has been minimized.

Show comment
Hide comment
@bgamari

bgamari May 30, 2017

Contributor

I actually didn't (or rather, haven't yet) encounter any other issues after bumping the jnr-posix version. So far things seem to "just work".

Contributor

bgamari commented May 30, 2017

I actually didn't (or rather, haven't yet) encounter any other issues after bumping the jnr-posix version. So far things seem to "just work".

@oleg-nenashev oleg-nenashev merged commit 7fe0621 into jenkinsci:master Jun 2, 2017

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details
@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Jun 2, 2017

Member

Current changelog proposal: "Update jnr-posix from 3.0.1 to 3.0.41 to pick improvements and fixes in the POSIX platforms support"

Member

oleg-nenashev commented Jun 2, 2017

Current changelog proposal: "Update jnr-posix from 3.0.1 to 3.0.41 to pick improvements and fixes in the POSIX platforms support"

@rmpestano rmpestano referenced this pull request in jenkinsci/cucumber-living-documentation-plugin Mar 9, 2018

Closed

Use Jenkins 2.73 as baseline #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment