New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Slave Installer Module to 1.6 #2965

Merged
merged 1 commit into from Aug 8, 2017

Conversation

4 participants
@oleg-nenashev
Copy link
Member

oleg-nenashev commented Aug 4, 2017

Changes to be integrated:

  • PR #1 - Cleanup issues reported by FindBugs
  • JENKINS-42841 - Replace the "slave" term by "agent" where possible. Now the module is called "Agent Installer Module"

Changelog: https://github.com/jenkinsci/slave-installer-module/blob/master/CHANGELOG.md#16

Proposed changelog entries

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@reviewbybees

Update Slave Installer Module to 1.6
* [PR #1](jenkinsci/slave-installer-module#1) - Cleanup issues reported by FisndBugs
* [JENKINS-42841](https://issues.jenkins-ci.org/browse/JENKINS-42841) - Replace the "slave" term by "agent" where possible

Changelog: https://github.com/jenkinsci/slave-installer-module/blob/master/CHANGELOG.md#16
@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Aug 4, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@daniel-beck

This comment has been minimized.

@jglick

jglick approved these changes Aug 4, 2017

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Aug 4, 2017

@reviewbybees done. I do not feel FindBugs issues are significant enough to changelog a defect. Hence it's just an RFE

@oleg-nenashev oleg-nenashev merged commit bc4f30a into jenkinsci:master Aug 8, 2017

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment