Join GitHub today
[JENKINS-21905] Present human readable error when archiving unreadable artifacts #2976
One of the reocuring reason for the cryptic failure in the JIRA is the fact artifacts are not readable for user running slave agent. The exceptions got a bit better since then so it involves the filename and the fact permissions was denied, but user is still staring at ~70 lines of stacktraces. Consolidate this to an easy to grasp message.
To do this, several levels of nested exceptions was removed as it was effectively hiding the root cause.
Proposed changelog entries
Sure, this is how it would look like:
The changes look good to me, excepting FilePath. Something is missing there imho
changed the title from
Present human readable error when archiving unreadable artifacts
[JENKINS-21905] Present human readable error when archiving unreadable artifacts
Sep 22, 2017
@olivergondza It's definitely ready to go, but I am not sure how to properly note it and how to properly squash it since there are 2 issues mentioned in commit history. IIUC JENKINS-21905 is just a diagnosability improvement on the top of JENKINS-19473.
Could you please integrate the change in a way you find the best?
Sep 24, 2017
1 check passed
added a commit
this pull request
Sep 24, 2017
Notably since https://jenkins.io/changelog/#v2.43 we're already listing the innermost exception on top. The actual error here was already on the first 2-3 lines.
@daniel-beck, right, for user consumption, yes. Though, the exception was cumbersome to act upon when wrapped in all that clutter and that is what this PR took advantage of.
Not that I agree we rearrange exception order like this in general - especially if we fail to be consistent doing that. The remoting exceptions are quire hard to navigate on its own and adding potential inverted listing, depending on which part of Jenkins has printed it, is not helping.