New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulgarian translation #2983

Merged
merged 2 commits into from Aug 22, 2017

Conversation

3 participants
@alshopov
Contributor

alshopov commented Aug 15, 2017

No description provided.

@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Aug 16, 2017

Member

Awesome! 🍻

I don't think we have anyone among regular contributors who speaks Bulgarian (or @oleg-nenashev maybe has hidden talents?), so I'll just give it a quick Google translate check to make sure it looks sane before merging (unfortunately, contributed translations haven't been in the past…).

Member

daniel-beck commented Aug 16, 2017

Awesome! 🍻

I don't think we have anyone among regular contributors who speaks Bulgarian (or @oleg-nenashev maybe has hidden talents?), so I'll just give it a quick Google translate check to make sure it looks sane before merging (unfortunately, contributed translations haven't been in the past…).

@daniel-beck daniel-beck self-assigned this Aug 16, 2017

@alshopov

This comment has been minimized.

Show comment
Hide comment
@alshopov

alshopov Aug 16, 2017

Contributor

Hi,

Take your time if you have to - this has been in the works for almost 2 years, will wait a bit more.

What I can do to increase your confidence in merging:

  1. I am a long time free and open source software translator - started circa 2000.
  2. I do have a lot of Bulgarian translations already done - such as bash, git, GNOME - and many, many others.
  3. This is not my first translation for Jenkins - see #1913

If you are wondering about the state of the translation - by my standards it is presentable to people. They will understand it and it can help them. It needs further testing for example some of the properties could be shortened in order to make the interface better looking. Current state also reflects terms in the English original. As they are a bit flaky - for example master/slave terminology is being phased out I will do further work on unification of therms there.

Contributor

alshopov commented Aug 16, 2017

Hi,

Take your time if you have to - this has been in the works for almost 2 years, will wait a bit more.

What I can do to increase your confidence in merging:

  1. I am a long time free and open source software translator - started circa 2000.
  2. I do have a lot of Bulgarian translations already done - such as bash, git, GNOME - and many, many others.
  3. This is not my first translation for Jenkins - see #1913

If you are wondering about the state of the translation - by my standards it is presentable to people. They will understand it and it can help them. It needs further testing for example some of the properties could be shortened in order to make the interface better looking. Current state also reflects terms in the English original. As they are a bit flaky - for example master/slave terminology is being phased out I will do further work on unification of therms there.

@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Aug 16, 2017

Member

In that case I'll save myself the time 👍 Thanks for your contribution.

We'll merge it towards the next weekly release unless something comes up.

Member

daniel-beck commented Aug 16, 2017

In that case I'll save myself the time 👍 Thanks for your contribution.

We'll merge it towards the next weekly release unless something comes up.

@oleg-nenashev

@alshopov @daniel-beck I can read the most of the text, but I cannot check grammar and typos since the language is quite different from Russian.

I am fine with merging without a detailed review, but it definitely requires a fix of hyperlinks. The translations have been done 1 year ago, and hence the change doe not reflect the website change to jenkins.io + Wiki redirect links from the main site. But these guys are minor fixes. Thanks for the translation!

@alshopov

This comment has been minimized.

Show comment
Hide comment
@alshopov

alshopov Aug 20, 2017

Contributor

Hey Oleg,
Thanx for noticing of links! I thought I eliminated all of these, sadly I missed some. I will correct.

Contributor

alshopov commented Aug 20, 2017

Hey Oleg,
Thanx for noticing of links! I thought I eliminated all of these, sadly I missed some. I will correct.

@alshopov

This comment has been minimized.

Show comment
Hide comment
@alshopov

alshopov Aug 20, 2017

Contributor

OK, @oleg-nenashev's request is done.
I have additionally fixed the example in ./core/src/main/resources/hudson/ProxyConfiguration/help-noProxyHost_bg.html:
./core/src/main/resources/hudson/ProxyConfiguration/help-noProxyHost.html mentions "www*.jenkins-ci.org" as a general pattern example. I have translated that to "w*.jenkins.io" which shows you can use "*" for part of name which matches "wiki.jenkins.io".

Contributor

alshopov commented Aug 20, 2017

OK, @oleg-nenashev's request is done.
I have additionally fixed the example in ./core/src/main/resources/hudson/ProxyConfiguration/help-noProxyHost_bg.html:
./core/src/main/resources/hudson/ProxyConfiguration/help-noProxyHost.html mentions "www*.jenkins-ci.org" as a general pattern example. I have translated that to "w*.jenkins.io" which shows you can use "*" for part of name which matches "wiki.jenkins.io".

@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Aug 20, 2017

Member

@oleg-nenashev Good find, thanks! Didn't even think of the redirect links. Can we merge this now, WDYT?

Member

daniel-beck commented Aug 20, 2017

@oleg-nenashev Good find, thanks! Didn't even think of the redirect links. Can we merge this now, WDYT?

@oleg-nenashev

Fine for merge if it does not collide with the release by @kohsuke

@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Aug 20, 2017

Member

Waiting for a good PR build. Seemed random but to be sure.

Member

daniel-beck commented Aug 20, 2017

Waiting for a good PR build. Seemed random but to be sure.

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Aug 21, 2017

Member

"java.lang.AssertionError: expected:<[]> but was:<[This Jenkins instance uses deprecated Remoting protocols: CLI-connect,CLI2-connect,JNLP-connect,JNLP2-connectIt may impact stability of the instance. If newer protocol versions are supported by all system components (agents, CLI and other clients), it is highly recommended to disable the deprecated protocols.]>
"

Maybe I caused it in the last weekly. Restarting the PR

Member

oleg-nenashev commented Aug 21, 2017

"java.lang.AssertionError: expected:<[]> but was:<[This Jenkins instance uses deprecated Remoting protocols: CLI-connect,CLI2-connect,JNLP-connect,JNLP2-connectIt may impact stability of the instance. If newer protocol versions are supported by all system components (agents, CLI and other clients), it is highly recommended to disable the deprecated protocols.]>
"

Maybe I caused it in the last weekly. Restarting the PR

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Aug 22, 2017

Member

🚢 🇮🇹

Member

oleg-nenashev commented Aug 22, 2017

🚢 🇮🇹

@oleg-nenashev oleg-nenashev merged commit 862de86 into jenkinsci:master Aug 22, 2017

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment