Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-46288] - Fix ProxyConfiguration validation for NTLM authentication #2984

Merged
merged 1 commit into from Aug 19, 2017

Conversation

3 participants
@bale836
Copy link
Contributor

commented Aug 16, 2017

The constructor of NTCredentials has one mistake order, host first then domain:

/**
* Constructor.
* @param userName The user name. This should not include the domain to authenticate with.
* For example: "user" is correct whereas "DOMAIN\user" is not.
* @param password The password.
* @param host The host the authentication request is originating from. Essentially, the
* computer name for this machine.
* @param domain The domain to authenticate within.
*/

Proposed changelog:

  • Bug: Proxy Configuration's "Validate" button in Update Manager / Advanced now works correctly when NTLM authorization is defined
Fix the new NTCredentials() mistake
/**
     * Constructor.
     * @param userName The user name.  This should not include the domain to authenticate with.
     * For example: "user" is correct whereas "DOMAIN\\user" is not.
     * @param password The password.
     * @param host The host the authentication request is originating from.  Essentially, the
     * computer name for this machine.
     * @param domain The domain to authenticate within.
     */
@daniel-beck

This comment has been minimized.

Copy link
Member

commented Aug 16, 2017

@bale836 What is the effect of this issue?

Perhaps @fbelzunc has an environment in which to test this fix in?

@bale836

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2017

@daniel-beck , my jenkins is behind the proxy with ntlm authentication, but i got 407 always.
I tcpdump the package, found the "host name" and "domain name" is reverse.

@oleg-nenashev
Copy link
Member

left a comment

it is a correct fix. NTLM support has been introduced by @escoem in 2.8 (81e00cc), but I doubt it has ever worked. Pull request: #1955

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Aug 18, 2017

Created https://issues.jenkins-ci.org/browse/JENKINS-46288 to have a placeholder for backporting to 2.73.x

@oleg-nenashev oleg-nenashev changed the title Fix the new NTCredentials() mistake [JENKINS-46288] - Fix ProxyConfiguration validation for NTLM authentication Aug 18, 2017

@oleg-nenashev oleg-nenashev merged commit ccb3e4c into jenkinsci:master Aug 19, 2017

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details

hplatou added a commit to hplatou/jenkins that referenced this pull request Aug 21, 2017

[JENKINS-46288] - Fix ProxyConfiguration validation for NTLM authenti…
…cation (jenkinsci#2984)

/**
     * Constructor.
     * @param userName The user name.  This should not include the domain to authenticate with.
     * For example: "user" is correct whereas "DOMAIN\\user" is not.
     * @param password The password.
     * @param host The host the authentication request is originating from.  Essentially, the
     * computer name for this machine.
     * @param domain The domain to authenticate within.
     */

olivergondza added a commit that referenced this pull request Sep 4, 2017

[JENKINS-46288] - Fix ProxyConfiguration validation for NTLM authenti…
…cation (#2984)

/**
     * Constructor.
     * @param userName The user name.  This should not include the domain to authenticate with.
     * For example: "user" is correct whereas "DOMAIN\\user" is not.
     * @param password The password.
     * @param host The host the authentication request is originating from.  Essentially, the
     * computer name for this machine.
     * @param domain The domain to authenticate within.
     */

(cherry picked from commit ccb3e4c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.