New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Jenkins Parent POM 1.38 #2985

Merged
merged 2 commits into from Aug 25, 2017

Conversation

4 participants
@oleg-nenashev
Member

oleg-nenashev commented Aug 16, 2017

It's downstream of jenkinsci/pom#14

Changelog entries

  • Internal: Jenkins core now requires Maven 3.3.9 or above to be built

@reviewbybees @aheritier @jglick

@reviewbybees

This comment has been minimized.

Show comment
Hide comment
@reviewbybees

reviewbybees Aug 16, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

reviewbybees commented Aug 16, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@recampbell recampbell requested a review from jglick Aug 16, 2017

@jglick

jglick approved these changes Aug 17, 2017

@@ -94,7 +94,6 @@ THE SOFTWARE.
<animal.sniffer.skip>${skipTests}</animal.sniffer.skip>
<findbugs-maven-plugin.version>3.0.4</findbugs-maven-plugin.version>
<findbugs.failOnError>true</findbugs.failOnError>
<test-annotations.version>1.2</test-annotations.version>
<access-modifier.version>1.11</access-modifier.version>

This comment has been minimized.

@jglick

jglick Aug 17, 2017

Member

I thought you planned to standardize on access-modifier too?

@jglick

jglick Aug 17, 2017

Member

I thought you planned to standardize on access-modifier too?

This comment has been minimized.

@oleg-nenashev

oleg-nenashev Aug 19, 2017

Member

Later. I am working on the proposal regarding that

@oleg-nenashev

oleg-nenashev Aug 19, 2017

Member

Later. I am working on the proposal regarding that

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev
Member

oleg-nenashev commented Aug 23, 2017

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Aug 24, 2017

Member

I am going to merge it tomorrow if there is no negative feedback

Member

oleg-nenashev commented Aug 24, 2017

I am going to merge it tomorrow if there is no negative feedback

@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Aug 24, 2017

Member

Typo in PR title?

Member

daniel-beck commented Aug 24, 2017

Typo in PR title?

@oleg-nenashev oleg-nenashev changed the title from Update to Jenkins Parent POM 1.39 to Update to Jenkins Parent POM 1.38 Aug 24, 2017

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Aug 24, 2017

Member

yes, fixed

Member

oleg-nenashev commented Aug 24, 2017

yes, fixed

@oleg-nenashev oleg-nenashev merged commit 12a949e into jenkinsci:master Aug 25, 2017

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment