New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-46282] - Update WinSW from 2.1.0 to 2.1.2 #2987

Merged
merged 2 commits into from Aug 19, 2017

Conversation

4 participants
@oleg-nenashev
Member

oleg-nenashev commented Aug 17, 2017

Fixes JENKINS-46282, which impacts the default installation.
Also updates Parent POM in the module

Full list of fixes:

Downstream of jenkinsci/windows-slave-installer-module#16

Full Diffs:

Proposed changelog entries

3 Bugs:

No tests in the Jenkins core, it is covered by WinSW autotests.

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@reviewbybees

[JENKINS-46282] - Update WinSW from 2.1.0 to 2.1.2
Fixes [JENKINS-46282](https://issues.jenkins-ci.org/browse/JENKINS-46282), which impacts the default installation.
Also updates Parent POM in the module

Full list of fixes:

- JENKINS-46282 - Runaway Process Killer extension was not using the stopTimeoutMs parameter
- [WinSW Issue #206](kohsuke/winsw#206) - Prevent printing of log entries in the `status` command
- [WinSW Issue #218](kohsuke/winsw#218) - Prevent hanging of the stop executable when its logs are not being drained do the parent process

Full Diff: kohsuke/winsw@winsw-v2.1.0...winsw-v2.1.2
@reviewbybees

This comment has been minimized.

Show comment
Hide comment
@reviewbybees

reviewbybees Aug 17, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

reviewbybees commented Aug 17, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@alexanderrtaylor

LGTM with a successful build
🐝

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Aug 18, 2017

Member

@reviewbybees done since there was no changes in the released version

Member

oleg-nenashev commented Aug 18, 2017

@reviewbybees done since there was no changes in the released version

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Aug 19, 2017

Member

@olblak @rtyler This is due to that Jenkins restart, right? I mean the pending build, which does not even time out

Member

oleg-nenashev commented Aug 19, 2017

@olblak @rtyler This is due to that Jenkins restart, right? I mean the pending build, which does not even time out

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Aug 19, 2017

Member

restarting CI, it may help

Member

oleg-nenashev commented Aug 19, 2017

restarting CI, it may help

@oleg-nenashev oleg-nenashev reopened this Aug 19, 2017

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Aug 19, 2017

Member

@jenkinsci/code-reviewers @daniel-beck WDYT though? 2.1.2 has been released in early July, no regressions reported by WinSW users.

Member

oleg-nenashev commented Aug 19, 2017

@jenkinsci/code-reviewers @daniel-beck WDYT though? 2.1.2 has been released in early July, no regressions reported by WinSW users.

@MarkEWaite

This comment has been minimized.

Show comment
Hide comment
@MarkEWaite

MarkEWaite Aug 19, 2017

Contributor

Does issue 237 affect this code?

If so, does this change make it any worse?

Contributor

MarkEWaite commented Aug 19, 2017

Does issue 237 affect this code?

If so, does this change make it any worse?

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Aug 19, 2017

Member

@MarkEWaite If that issue it real, it affects Jenkins as well (starting from 2.50). But I have been unable to reproduce it so far. It may be something specific to the .NET version. This change does not make it worse anyway

Member

oleg-nenashev commented Aug 19, 2017

@MarkEWaite If that issue it real, it affects Jenkins as well (starting from 2.50). But I have been unable to reproduce it so far. It may be something specific to the .NET version. This change does not make it worse anyway

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Aug 19, 2017

Member

Test is successful, 🚢 🇮🇹

Member

oleg-nenashev commented Aug 19, 2017

Test is successful, 🚢 🇮🇹

@oleg-nenashev oleg-nenashev merged commit 100202c into jenkinsci:master Aug 19, 2017

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details

hplatou added a commit to hplatou/jenkins that referenced this pull request Aug 21, 2017

[JENKINS-46282] - Update WinSW from 2.1.0 to 2.1.2 (#2987)
* [JENKINS-46282] - Update WinSW from 2.1.0 to 2.1.2

Fixes [JENKINS-46282](https://issues.jenkins-ci.org/browse/JENKINS-46282), which impacts the default installation.
Also updates Parent POM in the module

Full list of fixes:

- JENKINS-46282 - Runaway Process Killer extension was not using the stopTimeoutMs parameter
- [WinSW Issue #206](kohsuke/winsw#206) - Prevent printing of log entries in the `status` command
- [WinSW Issue #218](kohsuke/winsw#218) - Prevent hanging of the stop executable when its logs are not being drained do the parent process

Full Diff: kohsuke/winsw@winsw-v2.1.0...winsw-v2.1.2

* [JENKINS-46282] - Pick the released version of Windows Agent Installer

olivergondza added a commit that referenced this pull request Sep 4, 2017

[JENKINS-46282] - Update WinSW from 2.1.0 to 2.1.2 (#2987)
* [JENKINS-46282] - Update WinSW from 2.1.0 to 2.1.2

Fixes [JENKINS-46282](https://issues.jenkins-ci.org/browse/JENKINS-46282), which impacts the default installation.
Also updates Parent POM in the module

Full list of fixes:

- JENKINS-46282 - Runaway Process Killer extension was not using the stopTimeoutMs parameter
- [WinSW Issue #206](kohsuke/winsw#206) - Prevent printing of log entries in the `status` command
- [WinSW Issue #218](kohsuke/winsw#218) - Prevent hanging of the stop executable when its logs are not being drained do the parent process

Full Diff: kohsuke/winsw@winsw-v2.1.0...winsw-v2.1.2

* [JENKINS-46282] - Pick the released version of Windows Agent Installer

(cherry picked from commit 100202c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment