New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default the built-in Jenkins Update Center URL to https://updates.jenkins.io #2996

Merged
merged 1 commit into from Sep 2, 2017

Conversation

5 participants
@rtyler
Member

rtyler commented Aug 31, 2017

Now that we're using JDK8, we can rely on our Let's Encrypt-based certificates
on *.jenkins.io

Live from Jenkins World!

Changelog:

Signed-off-by: M. Allan max.allan@surevine.com
Signed-off-by: R. Tyler Croy tyler@monkeypox.org

@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Aug 31, 2017

Member

Related test failures in

@Test public void data() throws Exception {

Member

daniel-beck commented Aug 31, 2017

Related test failures in

@Test public void data() throws Exception {

Default the built-in Jenkins Update Center URL to https://updates.jen…
…kins.io

Now that we're using JDK8, we can rely on our Let's Encrypt-based certificates
on *.jenkins.io

Live from Jenkins World!

Signed-off-by: M. Allan <max.allan@surevine.com>
Signed-off-by: R. Tyler Croy <tyler@monkeypox.org>
@oleg-nenashev

LGTM 👍

@oleg-nenashev oleg-nenashev merged commit 4d60ca6 into jenkinsci:master Sep 2, 2017

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details
@casz

This comment has been minimized.

Show comment
Hide comment
@casz

casz Sep 5, 2017

Member

I think this should this be considered for back porting to the next LTS release

Member

casz commented Sep 5, 2017

I think this should this be considered for back porting to the next LTS release

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Sep 5, 2017

Member

@casz Makes sense. Could you please create an "lts-candidate" ticket in JIRA?

Member

oleg-nenashev commented Sep 5, 2017

@casz Makes sense. Could you please create an "lts-candidate" ticket in JIRA?

@casz

This comment has been minimized.

Show comment
Hide comment
Member

casz commented Sep 5, 2017

@orrc

This comment has been minimized.

Show comment
Hide comment
@orrc

orrc Sep 9, 2017

Member

Note that only Java versions >= 8u101 contain the roots for Let's Encrypt:
https://letsencrypt.org/docs/certificate-compatibility/#known-compatible

So users with a Java version < 8u101 will see failures, e.g. https://stackoverflow.com/q/46069600/234938

Member

orrc commented Sep 9, 2017

Note that only Java versions >= 8u101 contain the roots for Let's Encrypt:
https://letsencrypt.org/docs/certificate-compatibility/#known-compatible

So users with a Java version < 8u101 will see failures, e.g. https://stackoverflow.com/q/46069600/234938

@rtyler rtyler deleted the rtyler:update-center-https branch Sep 9, 2017

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Sep 10, 2017

Member
Member

oleg-nenashev commented Sep 10, 2017

@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Sep 10, 2017

Member

@oleg-nenashev Yes, towards 2.8y.x, in ~3 months.

Member

daniel-beck commented Sep 10, 2017

@oleg-nenashev Yes, towards 2.8y.x, in ~3 months.

@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Sep 10, 2017

Member

Newly set up instances on an old JRE 8 will complain that they're offline during the setup wizard. Can we really just assume everyone is on 8u101 or newer by now, after just ~14 months?

Member

daniel-beck commented Sep 10, 2017

Newly set up instances on an old JRE 8 will complain that they're offline during the setup wizard. Can we really just assume everyone is on 8u101 or newer by now, after just ~14 months?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment