New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Computer a DescriptorByNameOwner #3009

Merged
merged 2 commits into from Sep 10, 2017

Conversation

2 participants
@daniel-beck
Member

daniel-beck commented Sep 8, 2017

This will allow Computers to be used as AncestorInPath e.g. for
form validation.


Too trivial for new tests, or have an issue. Downstream demo PR could be a followup to https://github.com/jenkinsci/matrix-auth-plugin/pull/18/files#diff-4846dbdfaa05c64975de0e83c8b4273fR169 which more clearly demos the new behavior as that PR gracefully falls back to Overall/Administer if there's no @AncestorInPath Computer.

Tested locally with a snapshot though, and someone without Administer (just Computer/Configure) gets the form validation there.

CC @jglick who requested this.

Proposed changelog entries

  • Internal: Computer is now a DescriptorByNameOwner allowing its use as @AncestorInPath

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • [WIP] For new API and extension points: Link to the reference implementation in open-source (or example in Javadoc)
Make Computer a DescriptorByNameOwner
This will allow Computers to be used as AncestorInPath e.g. for
form validation.
@oleg-nenashev

👍

@daniel-beck daniel-beck merged commit 8f9ddca into jenkinsci:master Sep 10, 2017

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment