Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix JENKINS-42577] Save jenkins version in Jenkins.save() #3010

Merged
merged 2 commits into from Sep 22, 2017

Conversation

@liketic
Copy link
Contributor

liketic commented Sep 9, 2017

See JENKINS-42577.

Proposed changelog entries

Desired reviewers

@jglick

Copy link
Member

oleg-nenashev left a comment

👍

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Sep 9, 2017

Seems the change breaks the tests though:

test_getLastExecVersion – jenkins.install.InstallUtilTest
a few seconds
Error
expected:<[9.123]> but was:<[2.78-SNAPSHOT (private-09/09/2017 05:36 GMT-win2012-7f6630$)]>
Stacktrace
org.junit.ComparisonFailure: expected:<[9.123]> but was:<[2.78-SNAPSHOT (private-09/09/2017 05:36 GMT-win2012-7f6630$)]>
	at org.junit.Assert.assertEquals(Assert.java:115)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at jenkins.install.InstallUtilTest.test_getLastExecVersion(InstallUtilTest.java:126)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.jvnet.hudson.test.JenkinsRule$2.evaluate(JenkinsRule.java:551)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)

@oleg-nenashev oleg-nenashev merged commit 27569a9 into jenkinsci:master Sep 22, 2017
1 check passed
1 check passed
continuous-integration/jenkins/pr-head This commit looks good
Details
@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Sep 22, 2017

Thanks @liketic!

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Sep 22, 2017

Created the changelog entry. please verify

@daniel-beck

This comment has been minimized.

Copy link
Member

daniel-beck commented Sep 24, 2017

@jglick You requested a PR link in the issue, FYI this got merged into 2.80.

@jglick

This comment has been minimized.

Copy link
Member

jglick commented Sep 27, 2017

Caused JENKINS-47139.

@jglick jglick mentioned this pull request Sep 27, 2017
2 of 2 tasks complete
@liketic liketic deleted the liketic:bugfix/JENKINS-42577 branch Sep 27, 2017
@liketic

This comment has been minimized.

Copy link
Contributor Author

liketic commented Sep 28, 2017

@jglick Apologizes for my bad.

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Sep 28, 2017

That's why we have reviews :(
They just cannot replace basic smoke tests. We need to fix that

LinuxSuRen added a commit to suren-jenkins/jenkins that referenced this pull request Sep 29, 2017
…#3010)

* [Fix JENKINS-42577] Save jenkins version in Jenkins.save()

* [Fix JENKINS-42577] Fix unit test failures
@daniel-beck

This comment has been minimized.

Copy link
Member

daniel-beck commented Oct 15, 2017

Also caused JENKINS-47439 not fixed by #3050.

(BTW @liketic don't let any of this discourage you from contributing in the future. Mistakes happen.)

@liketic

This comment has been minimized.

Copy link
Contributor Author

liketic commented Oct 17, 2017

@daniel-beck Thanks for your kind. Please feel free to rollback this commit. Jenkins is a great project, I always happy to contribute. However, I'm not a expert on jenkins, for most of opened issues, I cannot figure out the context, so it's really hard to me to contribute to them. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.