New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Italian localization #3075

Merged
merged 1 commit into from Oct 28, 2017

Conversation

5 participants
@AlessandroMenti
Contributor

AlessandroMenti commented Oct 11, 2017

This pull request updates the Italian localization.

This change has no JIRA issue and no tests as it is relatively minor and because no Java code is altered.

I have (most of the times) kept the default copyright headers that were added by the translation tool to new files.

Proposed changelog entries

  • Italian localization updated.

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

No specific reviewer requested.

@daniel-beck daniel-beck self-requested a review Oct 11, 2017

@oleg-nenashev

This comment has been minimized.

Member

oleg-nenashev commented Oct 12, 2017

Maybe @varmenise could take a look

@AlessandroMenti

This comment has been minimized.

Contributor

AlessandroMenti commented Oct 12, 2017

I have now fixed some invalid Unicode characters I mistakenly left in two files.

There are still two test failures:

[ERROR] testDeleteRecursive_onWindows(hudson.UtilTest)  Time elapsed: 1.23 s  <<< FAILURE!
java.lang.AssertionError: deletion stopped
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertFalse(Assert.java:64)
	at hudson.UtilTest.testDeleteRecursive_onWindows(UtilTest.java:453)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:236)
	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:386)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:323)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:143)
[...]
[ERROR] noWarnings(jenkins.model.StartupTest)  Time elapsed: 4.126 s  <<< FAILURE!
java.lang.AssertionError: expected:<[]> but was:<[This Jenkins instance uses deprecated Remoting protocols: CLI-connect,CLI2-connect,JNLP-connect,JNLP2-connectIt may impact stability of the instance. If newer protocol versions are supported by all system components (agents, CLI and other clients), it is highly recommended to disable the deprecated protocols.]>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:834)
	at org.junit.Assert.assertEquals(Assert.java:118)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at jenkins.model.StartupTest.noWarnings(StartupTest.java:45)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:541)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.lang.Thread.run(Thread.java:748)

which, looking at the source code, seem not to be caused by my modifications.

@daniel-beck

This comment has been minimized.

Member

daniel-beck commented Oct 12, 2017

@AlessandroMenti The latter is a known flaky test, the former might be as well (Windows…). I'm starting another build.

@AlessandroMenti

This comment has been minimized.

Contributor

AlessandroMenti commented Oct 13, 2017

@daniel-beck It worked, thanks!

@oleg-nenashev

This comment has been minimized.

Member

oleg-nenashev commented Oct 20, 2017

I cannot review the text itself, but I do not see issues in the translation files (formatting & Co)

@oleg-nenashev

This comment has been minimized.

Member

oleg-nenashev commented Oct 26, 2017

@MarkEWaite

Molto bene! Grazie mille!

@oleg-nenashev

This comment has been minimized.

Member

oleg-nenashev commented Oct 28, 2017

Thanks @AlessandroMenti ! Merging it towards the next weekly

@oleg-nenashev oleg-nenashev merged commit cf69c29 into jenkinsci:master Oct 28, 2017

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details

@AlessandroMenti AlessandroMenti deleted the AlessandroMenti:update-italian-localization branch Nov 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment