New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-43834] Stop using deprecated ABORT permission #3101

Merged
merged 1 commit into from Oct 28, 2017

Conversation

5 participants
@abayer
Member

abayer commented Oct 20, 2017

See JENKINS-43834.

This is the only place it's actually referenced, so let's get rid of
it entirely.

Proposed changelog entries

  • Entry 1: JENKINS-43834, stop using the deprecated Job/ABORT permission in the build history widget.

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@reviewbybees

[FIXED JENKINS-43834] Stop using deprecated ABORT permission
This is the only place it's actually referenced, so let's get rid of
it entirely.
@reviewbybees

This comment has been minimized.

reviewbybees commented Oct 20, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick

jglick approved these changes Oct 20, 2017

Fine though it feels like even CANCEL is defined in the wrong place—could apply to non-Items.

@oleg-nenashev

This comment has been minimized.

Member

oleg-nenashev commented Oct 28, 2017

Fixed the changelog entry text

@oleg-nenashev

Merging

@oleg-nenashev oleg-nenashev merged commit 9518fac into jenkinsci:master Oct 28, 2017

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment