New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Manage Jenkins" icon on Global Tool Configuration #3139

Merged
merged 1 commit into from Nov 12, 2017

Conversation

4 participants
@mustafau
Contributor

mustafau commented Nov 11, 2017

All "Manage Jenkins" links from different pages use gear icon except this one.

Fix "Manage Jenkins" icon on Global Tool Configuration
All "Manage Jenkins" links from different pages use gear icon except this one.
@oleg-nenashev

LGTM

@recena

recena approved these changes Nov 12, 2017

@recena

This comment has been minimized.

Contributor

recena commented Nov 12, 2017

@mustafau For these visual changes, it is always better providing a screenshot before/after.

@oleg-nenashev oleg-nenashev merged commit a2fcfa0 into jenkinsci:master Nov 12, 2017

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details
@mustafau

This comment has been minimized.

Contributor

mustafau commented Nov 12, 2017

Adding before and after screenshots.

screen shot 2017-11-12 at 21 39 47
screen shot 2017-11-12 at 21 39 14

@daniel-beck

This comment has been minimized.

Member

daniel-beck commented Nov 12, 2017

Probably a race condition of sorts when I changed the icons and added the global tool configuration at the same time. Thanks for fixing it!

@recena

This comment has been minimized.

Contributor

recena commented Nov 13, 2017

Thanks!

@mustafau mustafau deleted the mustafau:patch-1 branch Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment