Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[JENKINS-47793] - Jenkins master and agent configuration pages do not verify negative executor numbers #3141
Field validation for "# of executors" did not work correctly in agent/master configuration pages. It was showing a page with an error and log on "Save". For agents it was also possible to set a negative number in the "# of executors" field.
After this fix:
Proposed changelog entries
referenced this pull request
Dec 28, 2017
oleg-nenashev left a comment
It seems that the error processing is not complete. The IllegalArgumentException exceptioneither needs to be thrown or removed from
It can be shipped now. Iirc it was just because of minor fixes after the previous @jglick's approval…
On Jan 30, 2018 09:42, "Daniel Beck" ***@***.***> wrote: @oleg-nenashev <https://github.com/oleg-nenashev> Why is this on-hold? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3141 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC3IoClMs1rJ72WW2QC5tPsY51OyOGpvks5tPtYPgaJpZM4Qdlaq> .