Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Introduce the new UserIdCause constructor, which accepts userId as an argument. #3162
I hit the issue with the missing constructor while working on jenkinsci/job-restrictions-plugin#20, ant actually it was not the first time I hit it. So I decided to add a new API method and to document the behavior while I was around.
Proposed changelog entries
No issue and no tests, just a minor developer update
changed the title from
Introduce UserIdCause constructor, which accepts userId as an argument.
Introduce the new UserIdCause constructor, which accepts userId as an argument.
Nov 27, 2017
referenced this pull request
Dec 6, 2017
The constructor seems fine in general, though I have strong reservations about the proposed downstream PR (and it is unclear to me whether the test would still exist in the same form if it were rewritten).
Anyway, I think the only issue here is the hyperlinking, which is wrong. OTOH it was wrong before, so this is not making anything worse really.
@jglick I have created https://issues.jenkins-ci.org/browse/JENKINS-48467 and referenced it from the code. Is it fine to go now assuming that the new API is useful in general? I agree that the downstream PR is not a right implementation of the issue fix, but IMHO it still offers a use-case for test environments at least