New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethrow any kind of RuntimeException, such as errors from RobustReflectionConverter #3167

Merged
merged 1 commit into from Dec 3, 2017

Conversation

2 participants
@jglick
Member

jglick commented Nov 29, 2017

Core counterpart to jenkinsci/workflow-api-plugin#54, which contains the full stack trace. One aspect of the problem was that XmlFile.write was catching and rethrowing a variety of errors, but not those rethrown by RobustReflectionConverter; thus code handling IOException was incomplete.

Proposed changelog entries

  • Better handling of certain unreproducible XML file load/save errors.

Desired reviewers

@reviewbybees

@oleg-nenashev

🐝

@jglick

This comment has been minimized.

Member

jglick commented Dec 1, 2017

@oleg-nenashev

This comment has been minimized.

Member

oleg-nenashev commented Dec 2, 2017

Maybe it needs a JIRA issue, not sure whether it may happen in the production (seems it actually may happen).

@oleg-nenashev

This comment has been minimized.

Member

oleg-nenashev commented Dec 3, 2017

We can create a ticket later if needed

@oleg-nenashev oleg-nenashev merged commit 6171221 into jenkinsci:master Dec 3, 2017

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details

@jglick jglick deleted the jglick:XmlFile branch Dec 4, 2017

jglick added a commit to jglick/jenkins that referenced this pull request Dec 4, 2017

Adjusting test after jenkinsci#3167, since now the rejection will bec…
…ome an IOException caught by Descriptor.save.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment