Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
export slave remote fs for json api #3206
changed the title from
export slave remove fs for json api
export slave remote fs for json api
Jan 5, 2018
Note that there are no automatic permission checks on method call AFAICT, you will need to do that yourself. So just handling an exception that never gets thrown won't work.
I'd feel a lot more confident about this change if it included a test that shows that low privilege users don't get to see the value.
Test failures definitely from the permission check as in my review:
This needs actual tests actually testing API output with and without Agent/Connect permission.