New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more refinements to ClassFilterImpl shutoff during development #3237

Merged
merged 1 commit into from Jan 18, 2018

Conversation

3 participants
@jglick
Member

jglick commented Jan 16, 2018

Should not be a user-visible change.

  1. Extend 475ef3a in #3120 to include java -jar jenkins.war (as opposed to mvn hpi:run) when supporting $JENKINS_HOME/plugins/*.jpl, as is occasionally useful.
  2. Fix some cases observed in ghprb-plugin (after jenkinsci/ghprb-plugin#615) where Jenkins fails to detect that Mockito is in use and the class filter needs to be disabled.

@reviewbybees

@jglick jglick requested a review from oleg-nenashev Jan 16, 2018

@reviewbybees

This comment has been minimized.

reviewbybees commented Jan 16, 2018

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@oleg-nenashev

I do not see issues here. 🐝 assuming it has been manually tested

return true;
}
if (loc.endsWith("/target/classes/")) {
LOGGER.log(Level.FINE, "{0} seems to be current plugin classes, OK", loc);

This comment has been minimized.

@jglick

jglick Jan 18, 2018

Member

Confirmed by linking …/mock-slave-plugin/target/test-classes/the.hpl to $JENKINS_HOME/plugins/mock-slave.jpl, creating a ClassFilterImpl logger, creating a mock slave, and running with plain java -jar jenkins.war:

file:…/mock-slave-plugin/target/classes/ seems to be current plugin classes, OK
permitting org.jenkinci.plugins.mock_slave.MockSlave due to its location in file:…/mock-slave-plugin/target/classes/

@jglick jglick merged commit 4f4af4e into jenkinsci:master Jan 18, 2018

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details

@jglick jglick deleted the jglick:ClassFilterImpl branch Jan 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment