New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-48766] - Expose information about Remoting versions via API #3250

Merged
merged 4 commits into from Jan 28, 2018

Conversation

4 participants
@oleg-nenashev
Member

oleg-nenashev commented Jan 22, 2018

See JENKINS-48766.

  • - Unrestrict API introduced in 2.101
  • - TcpAgent Listener returns information about minimum Remoting version. Handling on the Remoting side - TODO
  • - Jenkins master prints warnings when an agent older than a minimum version connects to the master
  • - Add Info about Minimum and Bundled versions to the manifest

Proposed changelog entries

  • RFE: Jenkins defines a minimum Remoting version and prints warnings when an older version is connected

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@reviewbybees @daniel-beck @Vlatombe

@oleg-nenashev

This comment has been minimized.

Member

oleg-nenashev commented Jan 22, 2018

Also CC @batmat since this API may be useful for extra checks in Version Column Plugin

@reviewbybees

This comment has been minimized.

reviewbybees commented Jan 22, 2018

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@batmat batmat self-requested a review Jan 22, 2018

@dwnusbaum dwnusbaum requested a review from rysteboe Jan 22, 2018

@@ -545,6 +547,12 @@ public void onClosed(Channel c, IOException cause) {
String slaveVersion = channel.call(new SlaveVersion());
log.println("Remoting version: " + slaveVersion);
VersionNumber agentVersion = new VersionNumber(slaveVersion);

This comment has been minimized.

@daniel-beck

daniel-beck Jan 22, 2018

Member

Not sure whether we still care, but I doubt the fallback < 1.335 will make a useful version number.

This comment has been minimized.

@oleg-nenashev

oleg-nenashev Jan 22, 2018

Member

I don't

@oleg-nenashev

This comment has been minimized.

Member

oleg-nenashev commented Jan 26, 2018

@oleg-nenashev oleg-nenashev merged commit dbc7512 into jenkinsci:master Jan 28, 2018

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment