New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-49070] - Whitelist BigDecimal and BigInteger #3251

Merged
merged 1 commit into from Jan 22, 2018

Conversation

6 participants
@oleg-nenashev
Copy link
Member

oleg-nenashev commented Jan 22, 2018

See JENKINS-49070. I think we may to whitelist classes in a core plugin like Pipeline Job since snippet generator gererates BigDecimal by default.

Proposed changelog entries

  • Entry 1: Whitelist BigDecimal and BigInteger types for XStream/Remoting serialization
  • ...

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@reviewbybees @jglick @abayer @svanoort (affects Pipeline)

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Jan 22, 2018

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick

This comment has been minimized.

Copy link
Member

jglick commented Jan 22, 2018

I think we may to whitelist classes in a core plugin like Pipeline Job

No, see JIRA.

since snippet generator gererates BigDecimal by default.

No it does not, see JIRA.

@jglick

jglick approved these changes Jan 22, 2018

@abayer

abayer approved these changes Jan 22, 2018

Copy link
Member

abayer left a comment

I think this will cover the issue with Declarative's possible ModelASTValue.values.

@oleg-nenashev

This comment has been minimized.

Copy link
Member Author

oleg-nenashev commented Jan 22, 2018

@reviewbybees done. Will create a hotfix PR

@oleg-nenashev

This comment has been minimized.

Copy link
Member Author

oleg-nenashev commented Jan 22, 2018

@oleg-nenashev oleg-nenashev merged commit b550c33 into jenkinsci:master Jan 22, 2018

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment