New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SSHD Module to 2.4 to bundle SSHD Core 1.7.0 #3278

Merged
merged 1 commit into from Feb 10, 2018

Conversation

5 participants
@oleg-nenashev
Member

oleg-nenashev commented Feb 4, 2018

Just an ongoing update, which pulls in some bugfixes to SSHD Core. IMO it should be merged after the LTS cutoff, just in case there are some issues with the new component.

Full diff: jenkinsci/sshd-module@sshd-2.3...sshd-2.4

Proposed changelog entries

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@jenkinsci/code-reviewers

@oleg-nenashev

This comment has been minimized.

Member

oleg-nenashev commented Feb 4, 2018

@jglick

jglick approved these changes Feb 8, 2018

it should be merged after the LTS cutoff

Eh, just do it. If we find issues we will deal with them.

@oleg-nenashev

This comment has been minimized.

Member

oleg-nenashev commented Feb 10, 2018

@reviewbybees done
@jenkinsci/code-reviewers any more votes regarding merge/wait?

@recena

This comment has been minimized.

Contributor

recena commented Feb 10, 2018

@MarkEWaite

This comment has been minimized.

Contributor

MarkEWaite commented Feb 10, 2018

I agree with @jglick. Merge before the LTS works for me.

@oleg-nenashev

This comment has been minimized.

Member

oleg-nenashev commented Feb 10, 2018

OK, community rating for the last 2 LTS look fine (excepting the whatever 50 cloudy votes overnight). 🚢 🇮🇹

@oleg-nenashev oleg-nenashev merged commit 041f901 into jenkinsci:master Feb 10, 2018

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details
@jglick

This comment has been minimized.

Member

jglick commented Feb 14, 2018

You should also update the sshd version in cli/pom.xml.

@daniel-beck

This comment has been minimized.

Member

daniel-beck commented Feb 14, 2018

@jglick @oleg-nenashev Is this a problem for our LTS?

@oleg-nenashev

This comment has been minimized.

Member

oleg-nenashev commented Feb 14, 2018

@daniel-beck no, it's not a problem. CLI and Master may safely have different versions. Created https://issues.jenkins-ci.org/browse/JENKINS-49565 as a follow-up though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment