New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LegacySecurityRealm should follow the databinding pattern #3279

Merged
merged 1 commit into from Feb 5, 2018

Conversation

2 participants
@kohsuke
Copy link
Member

kohsuke commented Feb 5, 2018

In order for this to behave more uniformly with other systems like CaC,
it's preferrable not to override the newInstance method and instead use
the standard annotation.

Issue: jenkinsci/configuration-as-code-plugin#24

Follow standard databinding pattern
In order for this to behave more uniformly with other systems like CaC,
it's preferrable not to override the newInstance method and instead use
the standard annotation.

Issue: jenkinsci/configuration-as-code-plugin#24

@kohsuke kohsuke requested a review from oleg-nenashev Feb 5, 2018

@kohsuke kohsuke merged commit 01a6558 into jenkinsci:master Feb 5, 2018

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details

@kohsuke kohsuke deleted the kohsuke:cac-24 branch Feb 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment