New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese translation #3287

Merged
merged 3 commits into from Feb 28, 2018

Conversation

3 participants
@LinuxSuRen
Member

LinuxSuRen commented Feb 13, 2018

Changelog entries:

  • RFE: Apply button caption is now localizable
  • RFE: Extend Chinese translations
@LinuxSuRen

This comment has been minimized.

Member

LinuxSuRen commented Feb 23, 2018

@jenkinsci/code-reviewers Anyone can help me to review?

@oleg-nenashev

Apply button localization is misplaced IMO. The form needs to be modified instead

@@ -97,7 +97,7 @@ l.layout(norefresh:true, permission:app.ADMINISTER, title:my.displayName, csscla
f.bottomButtonBar {
f.submit(value:_("Save"))
f.apply()
f.apply(value:_("Apply"))

This comment has been minimized.

@oleg-nenashev

oleg-nenashev Feb 23, 2018

Member

The default value should be localized in the form. Otherwise other buttons won't be modified. https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/lib/form/apply.jelly#L41

@LinuxSuRen

This comment has been minimized.

Member

LinuxSuRen commented Feb 24, 2018

@oleg-nenashev I already tested in multi-language env, and no problem. Can you tell me more issues detail?

@daniel-beck

This comment has been minimized.

Member

daniel-beck commented Feb 24, 2018

@LinuxSuRen There may be other uses of the Apply button that should also be localized, so @oleg-nenashev requests that you localize in the linked file instead. This will make the default label always localized.

@oleg-nenashev

👍 . Maybe the same applies to the submit button, but it is not changed in this PR

@LinuxSuRen

This comment has been minimized.

Member

LinuxSuRen commented Feb 26, 2018

Agree with your idea @oleg-nenashev , I will do this in next PR.

@oleg-nenashev oleg-nenashev merged commit 5fafb0b into jenkinsci:master Feb 28, 2018

1 check failed

continuous-integration/jenkins/pr-head This commit has test failures
Details

@LinuxSuRen LinuxSuRen deleted the suren-jenkins:suren-zh branch Mar 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment