Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-49543] - Add direct unit test for module class whitelisting #3290

Merged
merged 1 commit into from Feb 15, 2018

Conversation

2 participants
@oleg-nenashev
Copy link
Member

commented Feb 14, 2018

See JENKINS-49543. Cannot confirm the issue, but having a direct unit test would not hurt

Proposed changelog entries

  • N/A

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@reviewbybees @jglick

@jglick

jglick approved these changes Feb 14, 2018

@@ -149,6 +151,16 @@ public void xstreamRequiresWhitelist() throws Exception {
assertEquals(Collections.singleton(config), data.keySet());
assertThat(data.values().iterator().next().extra, allOf(containsString("LinkedListMultimap"), containsString("https://jenkins.io/redirect/class-filter/")));
}

@Test

This comment has been minimized.

Copy link
@jglick

jglick Feb 14, 2018

Member

@WithoutJenkins?

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Feb 14, 2018

Author Member

It would not be reliable just in case ClassFilterImpl tests require extension points & Co later

@oleg-nenashev

This comment has been minimized.

Copy link
Member Author

commented Feb 14, 2018

@oleg-nenashev oleg-nenashev merged commit 04bd7e6 into jenkinsci:master Feb 15, 2018

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.