New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose more mnemonic artifactId’s for modules not consumed externally #3311

Merged
merged 4 commits into from Mar 9, 2018

Conversation

4 participants
@jglick
Member

jglick commented Feb 26, 2018

No issue, no changelog needed. Just trying to make artifactIds be more consistent and independently meaningful.

In particular, test was weird. As of the creation of an independent jenkins-test-harness, this artifact is no longer consumed externally (it is not even deployed), so we can choose the name freely. The name of the parent POM is also of no consequence to outside consumers. It would be nice to rename cli to jenkins-cli but I fear that might break some external build (hard to say what exactly).

@reviewbybees @jenkinsci/code-reviewers

@daniel-beck daniel-beck self-requested a review Feb 26, 2018

@oleg-nenashev

It may collide with https://github.com/jenkinsci/pom/blob/master/pom.xml , but that guy also needs sosme cleanup in terms of naming. So 🐝

@jglick

This comment has been minimized.

Member

jglick commented Feb 27, 2018

I do not think it should “collide” in any way—what are you thinking of?

@oleg-nenashev

This comment has been minimized.

Member

oleg-nenashev commented Feb 28, 2018

I mean we have a naming overlap.
Anyway, @reviewbybees done

@jglick

This comment has been minimized.

Member

jglick commented Mar 2, 2018

we have a naming overlap

How so? That is org.jenkins-ci:jenkins. This proposes org.jenkins-ci.main:jenkins-parent.

@daniel-beck

Couldn't find affected infra, so seems reasonable.

jglick added some commits Mar 5, 2018

@oleg-nenashev

This comment has been minimized.

Member

oleg-nenashev commented Mar 9, 2018

merge conflict

@jglick jglick merged commit cfddf9f into jenkinsci:master Mar 9, 2018

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details

@jglick jglick deleted the jglick:artifactId branch Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment