New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit button localization #3319

Merged
merged 8 commits into from Mar 17, 2018

Conversation

4 participants
@LinuxSuRen
Member

LinuxSuRen commented Mar 1, 2018

No description provided.

@oleg-nenashev

This comment has been minimized.

Member

oleg-nenashev commented Mar 2, 2018

Maybe "Submit" by default? In such case we could cleanup Default usages in code and move localizations from https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/hudson/model/AbstractModelObject/descriptionForm.jelly (12 languages)

Lame attempt to find buttons with "Submit" text: https://github.com/jenkinsci/jenkins/search?utf8=%E2%9C%93&q=%22f%3Asubmit+value%3DSubmit%22&type=

@oleg-nenashev

This comment has been minimized.

Member

oleg-nenashev commented Mar 2, 2018

@LinuxSuRen

This comment has been minimized.

Member

LinuxSuRen commented Mar 4, 2018

Maybe 'Submit' is better, already changed. @oleg-nenashev

@oleg-nenashev

This comment has been minimized.

Member

oleg-nenashev commented Mar 4, 2018

@LinuxSuRen would you like to move localizations from hudson/model/AbstractModelObject/descriptionForm.jelly and cleanup default as I proposed above? If no, I will create a follow-up ticket for that

@LinuxSuRen

This comment has been minimized.

Member

LinuxSuRen commented Mar 5, 2018

I'd love to do that. @oleg-nenashev
There are many other language files in there. But I just add Chinese translation for 'Submit' as default.

@LinuxSuRen

This comment has been minimized.

Member

LinuxSuRen commented Mar 6, 2018

@oleg-nenashev What's your suggest?

@daniel-beck

This comment has been minimized.

Member

daniel-beck commented Mar 7, 2018

@LinuxSuRen Oleg is saying that descriptionForm.jelly overrode the label in a localizable manner, and its dozen or so resources files like descriptionForm_*.properties contain translations for this label already. Copying these contents into corresponding submit_*.properties will make all translations already apply this change.

@LinuxSuRen

This comment has been minimized.

Member

LinuxSuRen commented Mar 8, 2018

I know that mean, I just don't know other language. I can valid them through google translate.
@daniel-beck

@LinuxSuRen

This comment has been minimized.

Member

LinuxSuRen commented Mar 8, 2018

Sorry, I forgot I can't visit google.com in my city. But I pretty sure zh_TW's translate is not mean 'Submit'.

@daniel-beck

This comment has been minimized.

Member

daniel-beck commented Mar 8, 2018

I know that mean, I just don't know other language. I can valid them through google translate.

Well, if it's the same English text (Submit in both cases), it's likely to be correct, or at least close enough: Danish is 'Save', German is 'Apply', French, Spanish and Italian all seem to be 'Submit'. I think it's close enough to reuse it for this. IMO reuse of the equivalent translations for another UI element would still be a massive step forward, and a native speaker can always clean up the details.

But I pretty sure zh_TW's translate is not mean 'Submit'.

送出 is 'Send' according to translate.google.com, which seems to be close enough (at least to the level we review it here). The site won't let me distinguish between traditional and simplified Chinese in the source language though, don't know whether that's a problem. Translating it to either simplified or traditional only results in a minor change (AFAICT) in the left character.

@daniel-beck

This comment has been minimized.

Member

daniel-beck commented Mar 8, 2018

To clarify, I think (and @oleg-nenashev seems to agree) that it would be nice if you could include it, but we're not requiring it. If you're uncomfortable with providing translations for languages you don't know, just tell us you'd rather not to this here and we'll do it in a separate followup PR.

@LinuxSuRen

This comment has been minimized.

Member

LinuxSuRen commented Mar 8, 2018

I’d love do that. I appreciate your patient. But that traditional Chinese translate is not suitable. Maybe that because of the original author using google site. I will modify it.

@daniel-beck

This comment has been minimized.

Member

daniel-beck commented Mar 8, 2018

@LinuxSuRen That was @tan9 in #716. Perhaps it's just a confusion about the context of the label? Then again, the same translation for Submit occurs in a bunch of different files.

@LinuxSuRen

This comment has been minimized.

Member

LinuxSuRen commented Mar 8, 2018

Oh, I see.

@daniel-beck

This comment has been minimized.

Member

daniel-beck commented Mar 8, 2018

Then again, the same translation for Submit occurs in a bunch of different files.

To clarify, all of these translations contributed by the same author, so context doesn't seem to be the cause. Haven't checked beyond that PR.

@daniel-beck

This comment has been minimized.

Member

daniel-beck commented Mar 9, 2018

Now descriptionForm.jelly just needs to stop providing a custom label for f:submit and we should be good. 👍

@oleg-nenashev

The button localization looks good to me. There are also other default value usages which could be cleaned up though: https://github.com/jenkinsci/jenkins/search?utf8=%E2%9C%93&q=submit+value%3D%22%24%7B%25Submit%7D%22&type=

@LinuxSuRen

This comment has been minimized.

Member

LinuxSuRen commented Mar 10, 2018

Most of them already be remoted. @oleg-nenashev

@oleg-nenashev

LGTM assuming that we are fine with change of case in localizations. This part of localizations by editors is not clear to me, we are flip-flowing from "\u044f" to \u044F" and vice versa. But I cannot offer a good solution for that

@tan9

This comment has been minimized.

Member

tan9 commented Mar 12, 2018

@daniel-beck , @LinuxSuRen Submit be translated to 送出 is well-accepted in Taiwan, you can refer to Microsoft Terminology collection and find:

image

However, 提交 is also acceptable.

@LinuxSuRen

This comment has been minimized.

Member

LinuxSuRen commented Mar 12, 2018

Ok, I get it.

@LinuxSuRen

This comment has been minimized.

Member

LinuxSuRen commented Mar 17, 2018

Any more suggestion? @oleg-nenashev

@oleg-nenashev

This comment has been minimized.

Member

oleg-nenashev commented Mar 17, 2018

I think it's ready to go according to @tan9's comment. Since the most of commits are atomic, merging without squash

@oleg-nenashev oleg-nenashev merged commit 05ce7f7 into jenkinsci:master Mar 17, 2018

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details

@LinuxSuRen LinuxSuRen deleted the suren-jenkins:form-zh branch Mar 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment