Join GitHub today
Add parent loggers to autocompletion #3345
Subsumes #3344 while at the same time doing a LOT more work
Proposed changelog entries
referenced this pull request
Mar 13, 2018
After some tests, it seems that the autocomplete does not provide consistency among user input but over server response time.
I mean that if I type
To reproduce, put a breakpoint in
PS: it's not related to your solution. I opened a ticket.
In terms of UX, I think the user is more confident if he wants to use "org" and see it in the list explicitely. So it's a +1 from me.
Concerning the order, I think the insertion order is not relevant since the
Only small comment, nothing blocking.
No loggers in org.jenkinsci.main that aren't in org.jenkinsci.main.modules, so don't suggest that.
Nice UX improvement, good job
- thank you for the test, that avoid me to run the code with special case to be it works as expected :)