Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Chinese translation for global configuration #3355
Conversation
| @@ -0,0 +1,26 @@ | |||
| # The MIT License | |||
| # | |||
| # Copyright (c) 2004-2009, Sun Microsystems, Inc., Kohsuke Kawaguchi | |||
This comment has been minimized.
This comment has been minimized.
|
Should not be merged before existing translations have been migrated to the |
| @@ -62,7 +62,7 @@ THE SOFTWARE. | |||
|
|
|||
| <f:bottomButtonBar> | |||
| <f:submit value="${%Save}" /> | |||
| <f:apply value="${%Apply}"/> | |||
| <f:apply /> | |||
This comment has been minimized.
This comment has been minimized.
daniel-beck
Mar 17, 2018
Member
While the followup change to #3287 is not filed, this will remove existing translations without replacement.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
daniel-beck
Mar 17, 2018
Member
Yes, without moving the existing localizations to the f:apply control. It's similar to the discussion in #3319.
If we merge this change, system configuration will lose the apply button localization for Bulgarian, German, French, Italian, etc., as there are no corresponding translations to https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/lib/form/apply.jelly -- only English and Chinese.
This comment has been minimized.
This comment has been minimized.
LinuxSuRen
Mar 17, 2018
Author
Member
It's my mistake. So your option is put them back, or remove control to f:apply.
This comment has been minimized.
This comment has been minimized.
daniel-beck
Mar 17, 2018
Member
In my opinion, the preferable option --as in #3319 -- would be to just move the translations to apply_*.properties files.
If you don't wish to work on translations of languages you don't know, keeping the translations around and reverting part of this PR would also work.
This comment has been minimized.
This comment has been minimized.
|
@daniel-beck How do I should to deal with this pr? |
|
We will re-review it today |
|
Will need to re-review the localization situation after the linked PR was merged. |
|
Does something block this PR merge into master? |
|
Applys seem to have been restored. |
LinuxSuRen commentedMar 17, 2018
@oleg-nenashev