New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese translation for basic entry #3368

Merged
merged 2 commits into from Apr 14, 2018

Conversation

3 participants
@LinuxSuRen
Member

LinuxSuRen commented Mar 25, 2018

No description provided.

@LinuxSuRen

This comment has been minimized.

Member

LinuxSuRen commented Mar 28, 2018

@oleg-nenashev Please help to review.

@oleg-nenashev oleg-nenashev self-requested a review Mar 28, 2018

@oleg-nenashev

IMHO it needs cleanup of some entries, but it mostly fine (didn't review the text itself as you may guess)

UpdateCenter.PluginCategory.user=\u8ba4\u8bc1\u548c\u7528\u6237\u7ba1\u7406
UpdateCenter.PluginCategory.view=\u89c6\u56fe
UpdateCenter.PluginCategory.must-be-labeled=\u672a\u5206\u7c7b
UpdateCenter.PluginCategory.unrecognized=Misc ({0})

This comment has been minimized.

@oleg-nenashev

oleg-nenashev Mar 31, 2018

Member

Not sure you need localization entry in such case

This comment has been minimized.

@LinuxSuRen

LinuxSuRen Apr 7, 2018

Member

I already saw the page, it's fine after the jenkins running.

Label.ProvisionedFrom={0} \u7684\u4f9b\u5e94
ManageJenkinsAction.DisplayName=\u7CFB\u7EDF\u7BA1\u7406
MultiStageTimeSeries.EMPTY_STRING=

This comment has been minimized.

@oleg-nenashev

oleg-nenashev Mar 31, 2018

Member

Not required

FreeStyleProject.DisplayName=\u6784\u5EFA\u4E00\u4E2A\u81EA\u7531\u98CE\u683C\u7684\u8F6F\u4EF6\u9879\u76EE
FreeStyleProject.Description=\u8FD9\u662FJenkins\u7684\u4E3B\u8981\u529F\u80FD.Jenkins\u5C06\u4F1A\u7ED3\u5408\u4EFB\u4F55SCM\u548C\u4EFB\u4F55\u6784\u5EFA\u7CFB\u7EDF\u6765\u6784\u5EFA\u4F60\u7684\u9879\u76EE, \u751A\u81F3\u53EF\u4EE5\u6784\u5EFA\u8F6F\u4EF6\u4EE5\u5916\u7684\u7CFB\u7EDF.
HealthReport.EmptyString=

This comment has been minimized.

@oleg-nenashev

oleg-nenashev Mar 31, 2018

Member

Not required

This comment has been minimized.

@LinuxSuRen

LinuxSuRen Apr 7, 2018

Member

These are in other language files too, but I can't see where it's been used.

This comment has been minimized.

@daniel-beck

daniel-beck Apr 7, 2018

Member

@oleg-nenashev Even so, the tooling then considers these strings translated rather than missing.

Hudson.BadPortNumber=\u7aef\u53e3\u53f7\u9519\u8bef {0}
Hudson.Computer.Caption=Master
Hudson.Computer.DisplayName=master

This comment has been minimized.

@oleg-nenashev

oleg-nenashev Mar 31, 2018

Member

Not required (as well as some entries around)

This comment has been minimized.

@LinuxSuRen

LinuxSuRen Apr 7, 2018

Member

It's the same situation with above.

@oleg-nenashev

This comment has been minimized.

Member

oleg-nenashev commented Apr 7, 2018

@LinuxSuRen did you have a chance to process my comments?

@LinuxSuRen

This comment has been minimized.

Member

LinuxSuRen commented Apr 7, 2018

I just returned my vacation.
But I don't understand why those word should keep in English.
@oleg-nenashev

@oleg-nenashev

This comment has been minimized.

Member

oleg-nenashev commented Apr 14, 2018

OK, I agree with @daniel-beck's point about "Even so, the tooling then considers these strings translated rather than missing.". Merging it

@oleg-nenashev oleg-nenashev merged commit 6c4976f into jenkinsci:master Apr 14, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment