Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-50969] core site build is broken, needed for core taglibs reference #3408

Merged
merged 2 commits into from May 5, 2018

Conversation

@batmat
Copy link
Member

batmat commented Apr 26, 2018

The special old module for doxia seems not needed.
I suspect that it is because since 2012 when it was released, the Markdown
support got done in standard.

As this didn't get any update since 2012, IIUC this was pulling in some very old doxia versions, which was incompatible with maven-fluido-skin which I needed to bump from current 1.3.0 to 1.7 for https://github.com/jenkins-infra/core-taglibs-report-generator to work again.

See jenkins-infra/core-taglibs-report-generator#7 applied in practice.

See JENKINS-50969.

Proposed changelog entries

N/A internal change (maven-site-plugin only).

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@daniel-beck

@batmat batmat changed the title WIP [JENKINS-50969] core site build is broken, needed for core taglibs reference [JENKINS-50969] core site build is broken, needed for core taglibs reference Apr 26, 2018
@batmat batmat requested a review from daniel-beck Apr 26, 2018
@batmat
Copy link
Member Author

batmat commented Apr 27, 2018

Putting this on-hold as I would like it to not be merged before #3410 is merged and released in a weekly. BUT it is ready for review.

…ference

The special old module for doxia seems not needed.
I suspect that it is because since 2012 when it was released, the Markdown
support got done in standard.

IIUC this was pulling in some very old doxia versions, which was
incompatible with maven-fluido-skin which I needed to bump from current
1.3.0 to 1.7 for https://github.com/jenkins-infra/core-taglibs-report-generator
to work again.
@batmat batmat force-pushed the batmat:JENKINS-50969 branch from 2d517d6 to b3c5c40 Apr 27, 2018
pom.xml Outdated
@@ -28,7 +28,7 @@ THE SOFTWARE.
<parent>
<groupId>org.jenkins-ci</groupId>
<artifactId>jenkins</artifactId>
<version>1.41</version>
<version>1.42</version>

This comment has been minimized.

Copy link
@batmat

batmat Apr 27, 2018

Author Member

Bumps maven-site-plugin from 3.6 to 3.7. See jenkinsci/pom#21

@batmat batmat removed the on-hold label Apr 30, 2018
@batmat
Copy link
Member Author

batmat commented Apr 30, 2018

2.119 release is out, unon-holded

@oleg-nenashev
Copy link
Member

oleg-nenashev commented May 4, 2018

Parent POM update has been already done by @jglick in #3394
Resolved the merge conflict

@batmat
Copy link
Member Author

batmat commented May 4, 2018

Thanks a lot Oleg.

@oleg-nenashev oleg-nenashev merged commit 4278461 into jenkinsci:master May 5, 2018
2 checks passed
2 checks passed
continuous-integration/jenkins/incrementals Deployed to Incrementals.
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@batmat batmat deleted the batmat:JENKINS-50969 branch May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.