Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upPick-up parent pom 1.41 adding junit to dependencyManagement #3410
Conversation
|
FTR, filing this because I would like to pick up the 1.42 also soon, so I preferred to serialize changes so that we can possibly bisect things if something goes wrong. |
|
I would just go forward and pick 1.42. P.S. Apparently something does not work in the builder |
| @@ -149,7 +149,6 @@ THE SOFTWARE. | |||
| <dependency> | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
batmat
Apr 27, 2018
Author
Member
@oleg-nenashev not sure I get what you mean, removing the whole dependencyManagement section?
If so, then either I'm missing something, or I disagree: this would be out of scope for this change, and there are 10+ other dependencies declared there. So it would look like much more involved/risky. Some things like the servlet-api override are not even declared in the parent pom, so really I must be missing your point.
This comment has been minimized.
This comment has been minimized.
oleg-nenashev
Apr 27, 2018
Member
Just for junit, of course. The rest could be eventually removed as well (or moved to BOM), but this is a separate story
|
dependencyManagement section for junit needs to be removed entirely |
|
@oleg-nenashev fixed. |
|
Will merge it later today if nobody objects. Thanks for the review! |
|
@reviewbybees done |
batmat commentedApr 27, 2018
•
edited
Pick up jenkinsci/pom#19 which basically only adds
junittodependencyManagement.Full diff: https://github.com/jenkinsci/pom/compare/jenkins-1.40...jenkins-1.41?expand=1
No JIRA issue since this is a very small internal change and only touches the test code.
Proposed changelog entries
Internal:: N/A (only changes test framework)Submitter checklist
* Use the
Internal:prefix if the change has no user-visible impact (API, test frameworks, etc.)Desired reviewers
@reviewbybees esp. @oleg-nenashev