New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ${build.version} property in favor of ${project.version} #3430

Merged
merged 3 commits into from May 11, 2018

Conversation

4 participants
@jglick
Member

jglick commented May 9, 2018

After #3394 it is gratuitous to set a build.version property (apparently introduced in 5827fa9) to something like 2.121-SNAPSHOT (private-05/09/2018 18:05 GMT-jglick): snapshots are for local use, and if you wish to publish something (including an LTS RC!), JEP-305 allows you to use -Dset.changelist to give it a real version (if it was not already deployed for you automatically, that is). Allows us to simplify the build process a little bit.

@oleg-nenashev

Yey, less code!

jglick added some commits May 11, 2018

@jglick jglick merged commit 699ae01 into jenkinsci:master May 11, 2018

2 checks passed

continuous-integration/jenkins/incrementals Deployed to Incrementals.
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@jglick jglick deleted the jglick:no-build.version branch May 11, 2018

@daniel-beck

This comment has been minimized.

Member

daniel-beck commented May 14, 2018

@olivergondza

This comment has been minimized.

Member

olivergondza commented May 15, 2018

As I understand it, the LTS building never required the property to be passed explicitly[1] and internally it appears to be relying on project.version. Thanks for the heads-up, I believe we will be fine.

[1] https://github.com/jenkins-infra/backend-commit-history-parser/blob/472ef47485404b7daa0d1f422b919c78b0197ccb/bin/publish-lts-rc.sh#L16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment