Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-51965] - Added JAXB plugin as a split dependency #3510

Closed
wants to merge 3 commits into from

Conversation

3 participants
@kohsuke
Copy link
Member

commented Jun 20, 2018

See JENKINS-51965.

As a part of Java 9 support, we need to explicit carry around JAXB plug

https://github.com/jenkinsci/jaxb-plugin
jenkinsci/instance-identity-module#11

Proposed changelog entries

none

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@oleg-nenashev

@kohsuke kohsuke added the java11 label Jun 20, 2018

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Jun 22, 2018

@kohsuke IIUC your plan is to create another PR, right?

kohsuke added some commits Jun 22, 2018

[JENKINS-51965] bundle JAXB
After a failed initial attempt, falling back to a simpler option.

Servlet containers and EE containers are designed to tolerate this kind of setup where
the base system brings one version of JAXB and the app brings another
version because it's a common practice. When run in servlet containers
in Java 9+, this will ensure JAXB is available.

The version of JAXB bundled works with Java8.
@kohsuke

This comment has been minimized.

Copy link
Member Author

commented Jun 22, 2018

@oleg-nenashev and I talked and we decided to take a different more dumber approach. This PR now reflects that change

@oleg-nenashev oleg-nenashev self-assigned this Jun 22, 2018

@oleg-nenashev oleg-nenashev self-requested a review Jun 22, 2018

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Jun 22, 2018

I would like to do some testing before the merge, but looks good taking that we tried better options without success. The research is described in https://issues.jenkins-ci.org/browse/JENKINS-51965

@oleg-nenashev oleg-nenashev changed the title Added JAXB plugin as a split dependency [JENKINS-51965] - Added JAXB plugin as a split dependency Jun 22, 2018

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Jun 29, 2018

I tested it locally, and it looks good. But maybe it makes sense to review comments from @jglick in the ticket

@jenkinsci jenkinsci deleted a comment from qq97241481 Jul 2, 2018

@daniel-beck

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

@oleg-nenashev What is the status of this PR?

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

The plan is to investigate it next month

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Jan 28, 2019

Closing in favor of #3865 by @batmat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.