Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-52771] Bump up jna.jar version to 4.5.2 #3565

Merged
merged 2 commits into from Jul 30, 2018

Conversation

3 participants
@imdurgadas
Copy link
Contributor

imdurgadas commented Jul 28, 2018

Fixes https://issues.jenkins-ci.org/browse/JENKINS-52771.
JNA support for s390x is missing in 4.2.1. The support is added in 4.5.1 version as part of issue 845
Issue: java-native-access/jna#845
Commit : matthiasblaesing/jna@1fef4a2

See JENKINS-52771.

Changes: Bumped up version of jna to 4.5.1 in core/pom.xml

@oleg-nenashev - Please help review and merge.

Durgadas Kamath
Bump up jna.jar version to 4.5.1
Fixes https://issues.jenkins-ci.org/browse/JENKINS-52771.
JNA support for s390x is missing in 4.2.1. The support is added in 4.5.1 version as part of issue 845
Issue: java-native-access/jna#845
Commit : matthiasblaesing/jna@1fef4a2

@imdurgadas imdurgadas changed the title Bump up jna.jar version to 4.5.1 [JENKINS-52771] Bump up jna.jar version to 4.5.1 Jul 28, 2018

@oleg-nenashev
Copy link
Member

oleg-nenashev left a comment

why not 4.5.2 then? https://github.com/java-native-access/jna/blob/4.5.2/CHANGES.md#release-452

The changelog is pretty big, but the update looks fine. CC @ndeloof @dwnusbaum who may be interested

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Jul 28, 2018

Disclaimer: our existing test automation has no test automation for custom platforms. Such release will require monitoring in JIRA. I can provide that. Better to merge early so that it gets soaked well before LTS

@imdurgadas

This comment has been minimized.

Copy link
Contributor Author

imdurgadas commented Jul 29, 2018

@oleg-nenashev We had a fair amount of testing done with jna 4.5.1 so used the same to begin with to reduce risk of unusual behavior (if any).

When will this PR be merged ? When is the next release ?

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Jul 29, 2018

The next release is today. I would rather prefer to give others a chance to comment taking a major bump. Then it would be next week.

@imdurgadas

This comment has been minimized.

Copy link
Contributor Author

imdurgadas commented Jul 29, 2018

Sure. Thanks @oleg-nenashev . Let me know if there is anything needed from my side.

@dwnusbaum
Copy link
Member

dwnusbaum left a comment

It seems like it would make more sense to go straight to 4.5.2, but I'm fine with updating in general.

@imdurgadas It would be great to update JENKINS-52771 with a full stack trace of the specific linkage error you got so that we can investigate if it would be possible to replace that code path with pure Java code.

@imdurgadas

This comment has been minimized.

Copy link
Contributor Author

imdurgadas commented Jul 29, 2018

@dwnusbaum Thanks. Do you want me to bump the version to 4.5.2 as part of this PR ?
I have attached the entire stacktrace in JENKINS-52771.

Snippet of the Exception:
WARNING: Failed to list up hs_err_pid files java.lang.UnsatisfiedLinkError: Native library (com/sun/jna/linux-s390x/libjnidispatch.so) not found in resource path ([file:/var/cache/jenkins/war/WEB-INF/classes/, file:/var/cache/jenkins/war/WEB-INF/lib/access-modifier-annotation-1.14.jar, file:/var/cache/jenkins/war/WEB-INF/lib/acegi-security-1.0.7.jar, file:/var/cache/jenkins/war/WEB-INF/lib/activation-1.1.1-hudson-1.jar, file:/var/cache/jenkins/war/WEB-INF/lib/akuma-1.10.jar, file:/var/cache/jenkins/war/WEB-INF/lib/annotation-indexer-1.12.jar, file:/var/cache/jenkins/war/WEB-INF/lib/ant-1.9.2.jar, file:/var/cache/jenkins/war/WEB-INF/lib/ant-launcher-1.9.2.jar, file:/var/cache/jenkins/war/WEB-INF/lib/antlr-2.7.6.jar, file:/var/cache/jenkins/war/WEB-INF/lib/aopalliance-1.0.jar, file:/var/cache/jenkins/war/WEB-INF/lib/args4j-2.0.31.jar, file:/var/cache/jenkins/war/WEB-INF/lib/asm-5.0.3.jar,

@dwnusbaum

This comment has been minimized.

Copy link
Member

dwnusbaum commented Jul 29, 2018

@imdurgadas To me it seems like it makes more sense to go straight to the latest version in this PR since we are already bumping multiple minor versions, but I don't feel very strongly either way.

Thanks for attaching the stack trace to the ticket! Looks like the problematic code is HsErrPidList's use of Kohsuke's akuma library. I wonder if it would be better to catch errors around that line so JNA issues don't cause errors during Jenkins startup (might not be the only JNA use in startup, but this one at least seems non-critical). I will add a Jira comment next week in case we want to follow up on that in a separate ticket.

Durgadas Kamath

@imdurgadas imdurgadas changed the title [JENKINS-52771] Bump up jna.jar version to 4.5.1 [JENKINS-52771] Bump up jna.jar version to 4.5.2 Jul 30, 2018

@imdurgadas

This comment has been minimized.

Copy link
Contributor Author

imdurgadas commented Jul 30, 2018

@dwnusbaum @oleg-nenashev As per review comment above, I have bumped the version to 4.5.2.

@oleg-nenashev
Copy link
Member

oleg-nenashev left a comment

Happy to merge it towards the next weekly. I do not see incompatibility announcements in the changelog and commit history

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Jul 30, 2018

OK, let's see how it flies in the weekly

@oleg-nenashev oleg-nenashev merged commit 90eac31 into jenkinsci:master Jul 30, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.