New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parent POM #3567

Merged
merged 3 commits into from Aug 7, 2018

Conversation

7 participants
@jglick
Member

jglick commented Jul 30, 2018

Just to pick some up recent changes: jenkinsci/pom#26 jenkinsci/pom#27 jenkinsci/pom#28 jenkinsci/pom#29 plus proposed jenkinsci/pom#30

Do not merge without acknowledgement from @kohsuke! This is because a “reincrementalify” stage of the weekly release script might fail on the git-commit command when there is no change. CC @olblak

@jglick jglick requested a review from kohsuke Jul 30, 2018

jglick added some commits Jul 31, 2018

@jglick jglick requested a review from batmat Jul 31, 2018

@casz

casz approved these changes Jul 31, 2018

@batmat

batmat approved these changes Aug 2, 2018

@batmat batmat added the on-hold label Aug 2, 2018

@batmat

This comment has been minimized.

Show comment
Hide comment
@batmat

batmat Aug 6, 2018

Member

@kohsuke how can we test this ahead of releasing so that it does not fail for you during release? Thanks!

Member

batmat commented Aug 6, 2018

@kohsuke how can we test this ahead of releasing so that it does not fail for you during release? Thanks!

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Aug 6, 2018

Member

I have requested sign-off from Kohsuke by email. Stay tuned

Member

oleg-nenashev commented Aug 6, 2018

I have requested sign-off from Kohsuke by email. Stay tuned

jglick added a commit to jglick/backend-commit-history-parser that referenced this pull request Aug 6, 2018

@Wadeck

Wadeck approved these changes Aug 7, 2018

@kohsuke

kohsuke approved these changes Aug 7, 2018

Thanks for the heads up. Jesse clarified what I should anticipate, I'm ready to handle this. Let's merge this.

@jglick jglick removed the on-hold label Aug 7, 2018

@jglick jglick merged commit 81fbe02 into jenkinsci:master Aug 7, 2018

2 checks passed

continuous-integration/jenkins/incrementals Deployed to Incrementals.
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@jglick jglick deleted the jglick:new-parent branch Aug 7, 2018

@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Aug 8, 2018

Member

@jglick Is this the change that will make me change merge-up-security again?

Member

daniel-beck commented Aug 8, 2018

@jglick Is this the change that will make me change merge-up-security again?

@jglick

This comment has been minimized.

Show comment
Hide comment
@jglick
Member

jglick commented Aug 8, 2018

@daniel-beck yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment