New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop premature scroll bar on long build labels #3576

Merged
merged 1 commit into from Aug 11, 2018

Conversation

5 participants
@VirtualTim
Contributor

VirtualTim commented Aug 6, 2018

The build name width did not take into account the width/offset of the build icon. This resulted in a scroll bar being added prematurely.
Screenshot of change: https://i.imgur.com/RmercIT.png
Screenshot2: https://i.imgur.com/MW1JqZC.png

Stop premature scroll bar on long build labels
The build name width did not take into account the width/offset of the build icon. This resulted in a scroll bar being added prematurely.
Screenshot of change: https://i.imgur.com/RmercIT.png
@Wadeck

Wadeck approved these changes Aug 6, 2018

@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Aug 7, 2018

Member

Needs to be tested with build badges.

Member

daniel-beck commented Aug 7, 2018

Needs to be tested with build badges.

@VirtualTim

This comment has been minimized.

Show comment
Hide comment
@VirtualTim

VirtualTim Aug 8, 2018

Contributor

daniel-beck, you mean like the "keep forever" icon?
Looks good to me: https://i.imgur.com/MW1JqZC.png

Contributor

VirtualTim commented Aug 8, 2018

daniel-beck, you mean like the "keep forever" icon?
Looks good to me: https://i.imgur.com/MW1JqZC.png

@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Aug 8, 2018

Member

Yes, 'keep forever' is one badge of many possible ones. Thanks for that, I see they're on the next line anyway.

For reference, the builds list widget is historically one of the most annoying to change UI elements we have in all of Jenkins (besides those that for reasons simply cannot be changed). Basically every change results in regressions, including fixes to previous regressions. That's why I'm a bit careful here.

Member

daniel-beck commented Aug 8, 2018

Yes, 'keep forever' is one badge of many possible ones. Thanks for that, I see they're on the next line anyway.

For reference, the builds list widget is historically one of the most annoying to change UI elements we have in all of Jenkins (besides those that for reasons simply cannot be changed). Basically every change results in regressions, including fixes to previous regressions. That's why I'm a bit careful here.

@oleg-nenashev oleg-nenashev merged commit 0e5dc70 into jenkinsci:master Aug 11, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Aug 11, 2018

Member

Thanks for your contribution @VirtualTim !

Member

oleg-nenashev commented Aug 11, 2018

Thanks for your contribution @VirtualTim !

@peetereczek

This comment has been minimized.

Show comment
Hide comment
@peetereczek

peetereczek Aug 16, 2018

Hello,

Unfortunately after update (Jenkins 2.138), still i can see scroll bar: https://imgur.com/a/I2vCqqh
I noticed that after changing CSS display: inline-block to inline for that row, scroll bar disappears and textbox gets auto width. Now it looks fixed and scrollbar is shown.

peetereczek commented Aug 16, 2018

Hello,

Unfortunately after update (Jenkins 2.138), still i can see scroll bar: https://imgur.com/a/I2vCqqh
I noticed that after changing CSS display: inline-block to inline for that row, scroll bar disappears and textbox gets auto width. Now it looks fixed and scrollbar is shown.

@VirtualTim

This comment has been minimized.

Show comment
Hide comment
@VirtualTim

VirtualTim Aug 16, 2018

Contributor

Hm, I'll take a look Monday.
Crap, doesn't work on chrome. I think a 'better' fix is to remove the inline style="width: 100%;" from the build name class ("tip model-link inside build-link display-name"). But I can't see where that's being added in.

Contributor

VirtualTim commented Aug 16, 2018

Hm, I'll take a look Monday.
Crap, doesn't work on chrome. I think a 'better' fix is to remove the inline style="width: 100%;" from the build name class ("tip model-link inside build-link display-name"). But I can't see where that's being added in.

oleg-nenashev added a commit that referenced this pull request Sep 13, 2018

Better fix for "Stop premature scroll bar on long build labels" (#3576)…
… (#3601)

* Update hudson-behavior.js

* Remove previous workaround for scroll bars on build labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment