New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better fix for "Stop premature scroll bar on long build labels" (#3576) #3601

Merged
merged 2 commits into from Sep 13, 2018

Conversation

4 participants
@VirtualTim
Contributor

VirtualTim commented Aug 27, 2018

A better fix for the scroll bar issue I previously tried to fix in #3576. This should also work on Chrome. This also stops the caret from overflowing, which I assume is the correct behaviour.

Screenshot from chrome: https://i.imgur.com/jQQYvdP.png

I'm not sure why the width was being set from this function, maybe this was done before the width was managed by the css?

Desired reviewers

@peetereczek
@daniel-beck

VirtualTim added some commits Aug 27, 2018

@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Aug 29, 2018

Member

I hate to ask, but… Safari? IE?

Member

daniel-beck commented Aug 29, 2018

I hate to ask, but… Safari? IE?

@VirtualTim

This comment has been minimized.

Show comment
Hide comment
@VirtualTim

VirtualTim Aug 30, 2018

Contributor

Fair enough. I did test IE 11 before.
I just had a look at Edge and Safari 8.0.4, and they all look good.

Contributor

VirtualTim commented Aug 30, 2018

Fair enough. I did test IE 11 before.
I just had a look at Edge and Safari 8.0.4, and they all look good.

@Wadeck

Wadeck approved these changes Aug 31, 2018

I always like when an improvement can come from the removal of code, especially when it's CSS that was set in JS.

@oleg-nenashev

Nobody voted against, looks good to me taking the testing results

@oleg-nenashev oleg-nenashev merged commit e7de9a4 into jenkinsci:master Sep 13, 2018

2 checks passed

continuous-integration/jenkins/incrementals Deployed to Incrementals.
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment