Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-53401] Tie nodeProperties to the current node for save purpose #3609

Merged
merged 2 commits into from Sep 22, 2018

Conversation

4 participants
@Vlatombe
Copy link
Member

commented Sep 4, 2018

See JENKINS-53401.

Proposed changelog entries

  • Fixed a thread safety issue when creating several nodes in parallel.

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Sep 4, 2018

Wrong JIRA issue is referenced in the commit body. AFAICT you mean https://issues.jenkins-ci.org/browse/JENKINS-53401

@Vlatombe Vlatombe force-pushed the Vlatombe:JENKINS-53401 branch from 5682c97 to e38a97d Sep 4, 2018

@Vlatombe Vlatombe changed the title [JENKINS-53501] Tie nodeProperties to the current node for save purpose [JENKINS-53401] Tie nodeProperties to the current node for save purpose Sep 4, 2018

@Vlatombe

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2018

Good catch @oleg-nenashev, fixed.

@Vlatombe Vlatombe requested review from jglick and oleg-nenashev Sep 4, 2018

@daniel-beck

This comment has been minimized.

Copy link
Member

commented Sep 4, 2018

Is there a way to test this somewhat reliably with enough threads saving nodes?

@Vlatombe

This comment has been minimized.

Copy link
Member Author

commented Sep 7, 2018

@daniel-beck added a test

@daniel-beck daniel-beck merged commit b41a139 into jenkinsci:master Sep 22, 2018

2 checks passed

continuous-integration/jenkins/incrementals Deployed to Incrementals.
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

olivergondza added a commit that referenced this pull request Sep 26, 2018

Merge pull request #3609 from Vlatombe/JENKINS-53401
[JENKINS-53401] Tie nodeProperties to the current node for save purpose

(cherry picked from commit b41a139)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.