New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified Run.writeLogTo #3612

Merged
merged 1 commit into from Sep 13, 2018

Conversation

4 participants
@jglick
Member

jglick commented Sep 7, 2018

…by reverting 0dcf5ef, which should be obsolete since LargeText itself has long since supported gzipped files directly.

While tracking down an exception from jenkinsci/workflow-api-plugin#17 in a debugger, I found it being silently swallowed and the raw log dumped to HTML output instead.

Proposed changelog entries

  • Certain kinds of errors in build console display were being suppressed and ANSI escape sequences displayed instead.
@svanoort

It seems reasonable to me but I could see some unintended side effects of this.

@dwnusbaum

dwnusbaum approved these changes Sep 7, 2018 edited

Like Sam said, I think this makes sense, but I am a little concerned that this was catching errors unrelated to compression that will now be visible directly and cause regressions (e.g. #3613). Even so, it seems better to throw the exception so we can fix the actual issues.

@oleg-nenashev

Looks reasonable

@jglick

This comment has been minimized.

Show comment
Hide comment
@jglick

jglick Sep 8, 2018

Member

@dwnusbaum #3613 was, and is, caught (and logged at FINE) in ConsoleAnnotationOutputStream. This change merely brings writeLogTo (used for HTML output of a completed build) in line with other methods using [Annotated]LargeText, such as writeWholeLogTo. For that matter, HTML output of an in-progress build uses AnnotatedLargeText.doProgressiveHtml, which had no such fallback behavior.

Member

jglick commented Sep 8, 2018

@dwnusbaum #3613 was, and is, caught (and logged at FINE) in ConsoleAnnotationOutputStream. This change merely brings writeLogTo (used for HTML output of a completed build) in line with other methods using [Annotated]LargeText, such as writeWholeLogTo. For that matter, HTML output of an in-progress build uses AnnotatedLargeText.doProgressiveHtml, which had no such fallback behavior.

@oleg-nenashev oleg-nenashev merged commit 13da72a into jenkinsci:master Sep 13, 2018

2 checks passed

continuous-integration/jenkins/incrementals Deployed to Incrementals.
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@jglick jglick deleted the jglick:Run.writeLogTo branch Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment