Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate into localization-zh-cn-plugin #3667

Merged
merged 1 commit into from Oct 3, 2018

Conversation

3 participants
@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Oct 2, 2018

Maybe it makes sense to update Contributing.md to reference this case

@LinuxSuRen

This comment has been minimized.

Copy link
Member Author

LinuxSuRen commented Oct 2, 2018

You mean Contributing.md of Jenkins

@oleg-nenashev
Copy link
Member

oleg-nenashev left a comment

Yes. The rest LGTM

@oleg-nenashev oleg-nenashev merged commit 1a783f5 into jenkinsci:master Oct 3, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@LinuxSuRen LinuxSuRen deleted the LinuxSuRen:migrate-zh-pro branch Oct 4, 2018

@daniel-beck daniel-beck referenced this pull request Oct 14, 2018

Merged

Add Chinese localization for scheduler #3691

0 of 4 tasks complete
@daniel-beck

This comment has been minimized.

Copy link
Member

daniel-beck commented Oct 15, 2018

Per #3691, the changelog entry I've improvised for this is in fact wrong. @oleg-nenashev could we please stop merging PRs that don't follow the template?

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Oct 15, 2018

@daniel-beck agreed

@LinuxSuRen LinuxSuRen referenced this pull request Dec 17, 2018

Merged

Restore mis-remove localization files #3814

1 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.