Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-54731] Fix checkUpdateAttempts system property #3768

Merged
merged 1 commit into from Nov 23, 2018

Conversation

@MRamonLeon
Copy link
Contributor

commented Nov 20, 2018

Rename hudson.PluginManager.CHECK_UPDATE_ATTEMPTS system property to
hudson.PluginManager.checkUpdateAttempts

See JENKINS-54731.

It corrects a bug in the Pull Request #3718.
Don't forget to update this wiki page with the correct property: https://wiki.jenkins.io/display/JENKINS/Features+controlled+by+system+properties

Proposed changelog entries

  • Rename hudson.PluginManager.CHECK_UPDATE_ATTEMPTS system property to
    hudson.PluginManager.checkUpdateAttempts

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • N/A For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@reviewbybees

[JENKINS-54731] Fix checkUpdateAttempts system property
Rename hudson.PluginManager.CHECK_UPDATE_ATTEMPTS system property to
hudson.PluginManager.checkUpdateAttempts
@Wadeck
Wadeck approved these changes Nov 20, 2018
Copy link
Contributor

left a comment

The fix itself is good.

I think the only trouble is that your initial PR is backported to LTS but this one will not. Meaning users with LTS using this, will be annoyed.
IOW a warning in the release note is required.

@jvz
jvz approved these changes Nov 20, 2018
@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Nov 21, 2018

I plan to merge it towards the next weekly unless there is negative feedback

@oleg-nenashev oleg-nenashev self-assigned this Nov 21, 2018

@oleg-nenashev oleg-nenashev merged commit b6b7656 into jenkinsci:master Nov 23, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@MRamonLeon MRamonLeon deleted the MRamonLeon:JENKINS-54731 branch Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.