Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-55197] Correction of the InstallUncaught exception #3806

Merged

Conversation

6 participants
@Wadeck
Copy link
Contributor

commented Dec 12, 2018

Correction of the code that was not using the Jenkins instance provided as parameter of the method.

See JENKINS-55070 and JENKINS-55197.

Proposed changelog entries

  • Correction of the java.lang.IllegalStateException that occurs rarely on Jenkins startup

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • [n/a] Appropriate autotests or explanation to why this change has no tests
  • [n/a] For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@oleg-nenashev @daniel-beck

@Wadeck

This comment has been minimized.

Copy link
Contributor Author

commented Dec 12, 2018

Test failure not related:

  • hudson.model.QueueTest.testBlockBuildWhenUpstreamBuildingLock flaky due to sleep
@jvz

jvz approved these changes Dec 12, 2018

@Wadeck Wadeck closed this Dec 12, 2018

@Wadeck Wadeck reopened this Dec 12, 2018

@oleg-nenashev
Copy link
Member

left a comment

Maybe we need a separate placeholder issue to simplify backporting

@jeffret-b
Copy link
Contributor

left a comment

The change is good but I don't know how much this really impacts the referenced issue. In many cases this appears to be a symptom not a cause. This particular improvement may not improve those situations notably.

@Wadeck

This comment has been minimized.

Copy link
Contributor Author

commented Dec 14, 2018

@oleg-nenashev placeholder ticket created and description updated => JENKINS-55197.

@oleg-nenashev oleg-nenashev changed the title [JENKINS-55070] Correction of the InstallUncaught exception [JENKINS-55197] Correction of the InstallUncaught exception Dec 14, 2018

@oleg-nenashev oleg-nenashev merged commit 0c6a314 into jenkinsci:master Dec 14, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.