Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[JENKINS-47324] Use NIO in FilePath#isDirectory #3864
This came up as a possible improvement to help diagnose JENKINS-55356. Needs a test case at the least, and some investigation to understand the cases that previously would have returned false that would now throw exceptions to understand the risk of the change.
Known cases where the behavior changes between the old and new implementations:
Proposed changelog entries
Tests are passing, but the build failed on Java 11 due to a CNFE:
I don't think it was caused by this change, so I'll check if it has already been reported and if not, open a new ticket. EDIT: It looks similar to JENKINS-38072, although I'm not sure why we'd see it intermittently on ci.jenkins.io unless since I'd assume that our agents are configured correctly with a JDK matching the master.